🏷️ Label duplication warning (#1723)

jupyter-book · Jan 6, 2025 · 0d82810 · 0d82810
1 parent c5e5158
commit 0d82810
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/.changeset/lucky-squids-hug.md b/.changeset/lucky-squids-hug.md
@@ -0,0 +1,5 @@
+---
+"myst-common": patch
+---
+
+Improve label duplication warning
diff --git a/packages/myst-common/src/utils.ts b/packages/myst-common/src/utils.ts
@@ -90,11 +90,16 @@ export function createHtmlId(identifier?: string): string | undefined {
  */
 export function transferTargetAttrs(sourceNode: GenericNode, destNode: GenericNode, vfile?: VFile) {
   if (sourceNode.label) {
-    if (destNode.label && vfile) {
+    if (destNode.label && vfile && destNode.label !== sourceNode.label) {
       fileWarn(vfile, `label "${destNode.label}" replaced with "${sourceNode.label}"`, {
         node: destNode,
       });
     }
+    if (destNode.label && vfile && destNode.label === sourceNode.label) {
+      fileWarn(vfile, `duplicate label "${destNode.label}" replacement`, {
+        node: destNode,
+      });
+    }
     destNode.label = sourceNode.label;
     delete sourceNode.label;
   }