-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔢 Enable continuous numbering across pages #1391
base: main
Are you sure you want to change the base?
Conversation
What is this blocked on? Can I help in any way? |
I think it was blocked on requirements as we got a bit confused on how to actually do it! |
I don't think there is anything critical blocking this - I just stepped away from it and have not come back. The biggest thing I could use some input on is the frontmatter fields: In
In that case, it is ambiguous which takes priority. So, I think we should reconsider this frontmatter so this ambiguity is not possible. Maybe that means Beyond that, this PR just needs some more testing and bug fixing - the continuous numbering still doesn't quite work as expected everywhere. |
d1e74dc
to
e756be7
Compare
🦋 Changeset detectedLatest commit: e756be7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Picking this back up with franklin to get it over the line now! |
This adds an extra key to
numbering
fields -continue
. If true, the numbering of that type will continue counting from the previous page.This also adds title/page-level enumeration (which, combined with
continue
means you can have numbered chapters).Finally, this cleans up how frontmatter numbering
heading_#
relates to page heading depths. Now, the user-defined frontmatter levels match the user-defined heading depths, even if transforms have changed the depths in the mdast (for normalization, title lifting, etc).