-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🖲 [Spike] Add button
role
#1773
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Angus Hollands <angus@oieltd.com>
|
} | ||
const node: Link = { | ||
type: 'link', | ||
kind: 'button', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Buttons feel inherently link-like, i.e. they are not new node types, but more of a styling augmentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR (taking a quick look while in draft!). I am curious if there is going to be conceptually more to myst-ext-button
package in the future? In which case, maybe expanding the package name to cover it?
type: 'link', | ||
kind: 'button', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice - this means there is a good fallback.
Hey @rowanc1 ! Yeah @agoose77 and I were prototyping today and made a lot of pivots!
We very quickly found there's a myriad ways authors may want to style links, and initially borrowed some inspiration from the existing |
Makes sense, forgot about the card package as an analogy. |
Ref: 2i2c-org/infrastructure#5346
Co-authored-by: Angus Hollands angus@oieltd.com