📋 New lines in markdown lists are not written to typst #1777
Conversation
🦋 Changeset detectedLatest commit: c81f7fc The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| state.text(node.value); | ||
| // We do not want markdown formatting to be carried over to typst | ||
| // As the meaning in lists, etc. is different | ||
| state.text(node.value.replaceAll('\n', ' ')); |
There was a problem hiding this comment.
Things like this would be better handled in myst AST --- the AST should be designed to correctly abstract over new line behavior (new paragraph or item where it should be, etc.) and remove all newlines otherwise (normalize the text), so that backends don't handle this at all.
There was a problem hiding this comment.
This could certainly be done much further upstream, e.g. at markdown parse. I don't think there are any consequences of that. Other backends (latex/word/jats) are not effected by these new lines. It is possible that a markdown round-trip would be.
We don't currently have a node for a stylistic-only-in-the-source-newline. Are you suggesting we just remove it all together?
There was a problem hiding this comment.
It's a design decision to consider: to normalize the text to remove double spaces and new lines, since then in the backend you just pass the text to the renderer (typst in this case) and it will always work. You will not round-trip to the original markdown (I don't know if it is a problem). If you need to round-trip, then I think you need to keep the text exactly as-is (as you do now) and take care of it in the backend (or a separate pass), like you did above.
Fixes #1767