Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

closes #1776 to make tag/tags in markdown work with jupytext #1780

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tobydriscoll
Copy link

Closes #1776

Copy link

changeset-bot bot commented Jan 14, 2025

⚠️ No Changeset found

Latest commit: 7a03970

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@@ -43,7 +43,7 @@ Here's an example of adding this tag with a {myst:directive}`code-cell` directiv

````markdown
```{code-cell}
:tags: raises-exception
:tag: raises-exception
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work in jupytext?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think jupytext uses tags, rather than tag. Though it does use square brackets for multiple tags.

https://jupytext.readthedocs.io/en/latest/formats-markdown.html

My feeling is that we should define the syntax we want for MyST, and then upstream the improvements to jupytext to make it work, rather than the other way around

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked by running examples that "tag" works for a single string while "tags" requires brackets in jupytext.

I think it's important to keep documentation in sync with reality as much as possible. I was asked to help, and changing the docs is all I am qualified to do.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change this all to tags: [raises-exception], that should work in both myst and jupytext correct?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that works.

Copy link
Contributor

@agoose77 agoose77 Jan 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More broadly, options should be parsed as YAML if we're inheriting the spec from myst-parser / myst-nb, etc. I'm broadly in favour of this, because we already use YAML in other user-facing places, and it's a well-known standard to point to.

So, even if we don't actually use yaml.load, I'd like us to use the same standard. Therefore, we should treat tags: "" as something that we upgrade and deprecate.

As for tag -- it's not something we supported in myst-nb, so it's really just a question of whether we want more configuration or not. I'm tempted to not support it yet, because we don't have to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tags in md files require square brackets for jupytext
4 participants