Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added generic ffmpeg package helper and updated sample wav file #2311

Merged
merged 5 commits into from
Oct 21, 2023

Conversation

YellowFoxH4XOR
Copy link
Contributor

Fixes

This PR resolves #2310

What does this PR do?

Added a function to identify the new ffmpeg binary and move it accordingly. Also updated the example wav file as the older one was not found.

Screenshots

Provide supporting docs, limitations if any, video of the template, or anything that you want to share to support your PR
image

@YellowFoxH4XOR YellowFoxH4XOR self-assigned this Oct 15, 2023
@YellowFoxH4XOR YellowFoxH4XOR added the bug Something isn't working label Oct 15, 2023
Copy link
Member

@srini047 srini047 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Reorder the cells, since I see the find_directory_starting_with_ffmpeg_git well before the import libraries. And the find_directory_starting_with_ffmpeg_git must come under the Model section.
  • You could add *.xz in the .gitignore to keep the git commit clean.
  • Add your name besides in the Author: cell

@YellowFoxH4XOR
Copy link
Contributor Author

  • Reorder the cells, since I see the find_directory_starting_with_ffmpeg_git well before the import libraries. And the find_directory_starting_with_ffmpeg_git must come under the Model section.
  • You could add *.xz in the .gitignore to keep the git commit clean.
  • Add your name besides in the Author: cell

Thanks @srini047 for the review comments. I have addressed them but there is one issue with the first comment as pydub is dependent on ffmpeg so need to append the ffmpeg binary path to the environment variable before importing pydub. I have added proper markdowns for the same.

Copy link
Member

@srini047 srini047 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🚀

@FlorentLvr Do have a look if there is anything else to be added or removed.

@FlorentLvr
Copy link
Contributor

LGTM🚀

@FlorentLvr Do have a look if there is anything else to be added or removed.

Sure! I will try to have a look tonight or tomorrow morning :)

@FlorentLvr FlorentLvr merged commit 491b40b into master Oct 21, 2023
5 checks passed
@FlorentLvr FlorentLvr deleted the 2310-bugfix-python-convert-audiofile branch October 21, 2023 05:58
@github-actions
Copy link

The template is now available on the master branch on this link:
https://github.com/jupyter-naas/awesome-notebooks/blob/master/Python/Python_Convert_audiofile_from_wav_to_mp3.ipynb

@github-actions
Copy link

Thank you for your contribution @YellowFoxH4XOR, your PR has been merged into the master branch of awesome-notebook.
Here is the contribution certificate you can share on social media so everybody knows how awesome you are 🤙🌎.
Spread the #opensource love 💚

YellowFoxH4XOR.png

@FlorentLvr FlorentLvr added the hacktoberfest-accepted Valid PRs for hacktoberfest label Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hacktoberfest-accepted Valid PRs for hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python[Convert audiofile from wav to mp3] - Download ffmpeg mv command is failing due to newer version
3 participants