-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Added generic ffmpeg package helper and updated sample wav file #2311
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Reorder the cells, since I see the
find_directory_starting_with_ffmpeg_git
well before the import libraries. And thefind_directory_starting_with_ffmpeg_git
must come under theModel
section. - You could add
*.xz
in the.gitignore
to keep the git commit clean. - Add your name besides in the
Author:
cell
Thanks @srini047 for the review comments. I have addressed them but there is one issue with the first comment as pydub is dependent on ffmpeg so need to append the ffmpeg binary path to the environment variable before importing pydub. I have added proper markdowns for the same. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM🚀
@FlorentLvr Do have a look if there is anything else to be added or removed.
Sure! I will try to have a look tonight or tomorrow morning :) |
The template is now available on the master branch on this link: |
Thank you for your contribution @YellowFoxH4XOR, your PR has been merged into the master branch of awesome-notebook. |
Fixes
This PR resolves #2310
What does this PR do?
Added a function to identify the new ffmpeg binary and move it accordingly. Also updated the example wav file as the older one was not found.
Screenshots
Provide supporting docs, limitations if any, video of the template, or anything that you want to share to support your PR