Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pie-select): DSW-2774 add option and option group shell components #2278

Merged
merged 15 commits into from
Mar 17, 2025

Conversation

raoufswe
Copy link
Member

@raoufswe raoufswe commented Mar 13, 2025

Describe your changes (can list changeset entries if preferable)

  • Added the pie-option and pie-option-group shell sub components
  • Modified the webc package script to support exporting sub components
  • The functionality of these components will be done in a separate PR to reduce the PR size

Author Checklist (complete before requesting a review, do not delete any)

  • I have performed a self-review of my code.
  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • If changes will affect consumers of the package, I have created a changeset entry.
  • If a changeset file has been created, I have tested these changes in PIE Aperture using the /test-aperture command.
  • I have filled out the DS Review Tracker checklist (Moving PR to "Ready to Review")

Not-applicable Checklist items

Please move any Author checklist items that do not apply to this pull request here.

  • I have reviewed visual test updates properly before approving.
  • I have added thorough tests where applicable (unit / component / visual).

Testing

How do I test my changes?

Task Link
Aperture PR 🔗
NextJS 14 deployment 🔗
Nuxt 3 deployment 🔗
Vanilla deployment 🔗

Reviewer checklists (complete before approving)

Mark items as [-] N/A if not applicable.

Reviewer 1

  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • [-] I have reviewed the Aperture changes (if added)
  • [-] If there are visual test updates, I have reviewed them.

Reviewer 2 - @fernandofranca

  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • [-] I have reviewed the Aperture changes (if added)
  • [-] If there are visual test updates, I have reviewed them.

@raoufswe raoufswe requested review from a team as code owners March 13, 2025 11:25
@raoufswe raoufswe self-assigned this Mar 13, 2025
Copy link

changeset-bot bot commented Mar 13, 2025

🦋 Changeset detected

Latest commit: 35171dc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@justeattakeaway/pie-components-config Patch
@justeattakeaway/pie-select Minor
pie-storybook Minor
@justeattakeaway/pie-webc Patch
wc-angular12 Patch
wc-nuxt2 Patch
wc-react17 Patch
wc-react18 Patch
wc-vue3 Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@raoufswe raoufswe changed the title Dsw 2774 select option feat(DSW-2774) add select option and option group Mar 13, 2025
@raoufswe

This comment was marked as outdated.

@pie-design-system-bot

This comment was marked as outdated.

@pie-design-system-bot

This comment was marked as outdated.

@raoufswe

This comment was marked as outdated.

@pie-design-system-bot

This comment was marked as outdated.

@pie-design-system-bot

This comment was marked as outdated.

@raoufswe

This comment was marked as outdated.

@pie-design-system-bot

This comment was marked as outdated.

@pie-design-system-bot

This comment was marked as outdated.

@raoufswe

This comment was marked as outdated.

@pie-design-system-bot

This comment was marked as outdated.

@pie-design-system-bot

This comment was marked as outdated.

@raoufswe raoufswe marked this pull request as ready for review March 14, 2025 15:53
@raoufswe raoufswe changed the title feat(DSW-2774) add select option and option group feat(pie-select): DSW-2774 add option and option group shell components Mar 14, 2025
@raoufswe raoufswe marked this pull request as draft March 14, 2025 16:11
@raoufswe raoufswe marked this pull request as ready for review March 14, 2025 16:14
@raoufswe

This comment was marked as outdated.

@pie-design-system-bot

This comment was marked as outdated.

@pie-design-system-bot

This comment was marked as outdated.

@raoufswe raoufswe marked this pull request as draft March 14, 2025 17:00
@raoufswe raoufswe closed this Mar 14, 2025
@raoufswe raoufswe reopened this Mar 14, 2025
@raoufswe raoufswe marked this pull request as ready for review March 14, 2025 17:09
@raoufswe
Copy link
Member Author

/snapit

@pie-design-system-bot
Copy link
Contributor

Starting a new snapshot build. You can view the logs here.

@pie-design-system-bot
Copy link
Contributor

@raoufswe Your snapshots have been published to npm!

Test the snapshots by updating your package.json with the newly-published versions:

Note

If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts.

yarn up @justeattakeaway/pie-components-config@0.0.0-snapshot-release-20250314171339 --mode=update-lockfile
yarn up @justeattakeaway/pie-select@0.0.0-snapshot-release-20250314171339 --mode=update-lockfile
yarn up @justeattakeaway/pie-webc@0.0.0-snapshot-release-20250314171339 --mode=update-lockfile

Then finally:

yarn install

@raoufswe raoufswe merged commit 2efac2e into main Mar 17, 2025
56 of 59 checks passed
@raoufswe raoufswe deleted the dsw-2774-select-option branch March 17, 2025 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants