Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pie-modal): DSW-2870 add optional footer slot #2315

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

fernandofranca
Copy link
Contributor

@fernandofranca fernandofranca commented Apr 7, 2025

Describe your changes (can list changeset entries if preferable)

@justeattakeaway/pie-modal

[Added] - slot for custom footer content
[Fixed] - missing value in visual test

pie-docs

[Updated] - Modal code documentation for footer slot

pie-storybook

[Added] - story for footer slot

Author Checklist (complete before requesting a review, do not delete any)

  • I have performed a self-review of my code.
  • I have added thorough tests where applicable (unit / component / visual).
  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have reviewed visual test updates properly before approving.
  • If changes will affect consumers of the package, I have created a changeset entry.
  • If a changeset file has been created, I have tested these changes in PIE Aperture using the /test-aperture command.
  • I have filled out the DS Review Tracker checklist (Moving PR to "Ready to Review")

Not-applicable Checklist items

Please move any Author checklist items that do not apply to this pull request here.


Testing

How do I test my changes?

Task Link
Aperture PR 🔗
NextJS 14 deployment 🔗
Nuxt 3 deployment 🔗
Vanilla deployment 🔗

Reviewer checklists (complete before approving)

Mark items as [-] N/A if not applicable.

Reviewer 1

  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • I have reviewed the Aperture changes (if added)
  • If there are visual test updates, I have reviewed them.

Reviewer 2

  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • I have reviewed the Aperture changes (if added)
  • If there are visual test updates, I have reviewed them.

@fernandofranca fernandofranca requested review from a team as code owners April 7, 2025 10:10
Copy link

changeset-bot bot commented Apr 7, 2025

🦋 Changeset detected

Latest commit: f1ab7ec

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@justeattakeaway/pie-modal Minor
pie-docs Minor
pie-storybook Minor
@justeattakeaway/pie-cookie-banner Patch
@justeattakeaway/pie-webc Patch
wc-nuxt2 Patch
wc-react17 Patch
wc-react18 Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pie-design-system-bot
Copy link
Contributor

pie-design-system-bot commented Apr 7, 2025



Fails
🚫 You have unchecked checklist items outside the "Not-applicable Checklist items" section.

Please ensure all unchecked checkboxes are moved to the appropriate section.

🚫 You have unchecked checklist items in Reviewer 2's section.

Please ensure all items are addressed before approval.

Generated by 🚫 dangerJS against f1ab7ec

@github-actions github-actions bot temporarily deployed to storybook-pr-2315 April 7, 2025 10:15 Inactive
@github-actions github-actions bot temporarily deployed to storybook-testing-pr-2315 April 7, 2025 10:15 Inactive
@fernandofranca fernandofranca force-pushed the dsw-2870-pie-modal-optional-footer-slot branch from 2711539 to f15e31d Compare April 7, 2025 12:42
@github-actions github-actions bot temporarily deployed to storybook-pr-2315 April 7, 2025 12:47 Inactive
@github-actions github-actions bot temporarily deployed to storybook-testing-pr-2315 April 7, 2025 12:47 Inactive
@fernandofranca fernandofranca force-pushed the dsw-2870-pie-modal-optional-footer-slot branch from f15e31d to bfd071f Compare April 7, 2025 13:34
@github-actions github-actions bot temporarily deployed to storybook-testing-pr-2315 April 7, 2025 13:38 Inactive
@github-actions github-actions bot temporarily deployed to storybook-pr-2315 April 7, 2025 13:38 Inactive
@fernandofranca fernandofranca force-pushed the dsw-2870-pie-modal-optional-footer-slot branch from bfd071f to a9f49e2 Compare April 7, 2025 14:45
@github-actions github-actions bot temporarily deployed to storybook-pr-2315 April 7, 2025 14:50 Inactive
@github-actions github-actions bot temporarily deployed to storybook-testing-pr-2315 April 7, 2025 14:50 Inactive
@fernandofranca fernandofranca force-pushed the dsw-2870-pie-modal-optional-footer-slot branch from a9f49e2 to 07e5fc9 Compare April 7, 2025 15:31
@github-actions github-actions bot temporarily deployed to storybook-pr-2315 April 7, 2025 15:35 Inactive
@github-actions github-actions bot temporarily deployed to storybook-testing-pr-2315 April 7, 2025 15:35 Inactive
@github-actions github-actions bot temporarily deployed to storybook-pr-2315 April 8, 2025 07:58 Inactive
@fernandofranca fernandofranca force-pushed the dsw-2870-pie-modal-optional-footer-slot branch from d6fd437 to f1f9a40 Compare April 8, 2025 13:41
@github-actions github-actions bot temporarily deployed to storybook-pr-2315 April 8, 2025 13:45 Inactive
@github-actions github-actions bot temporarily deployed to storybook-testing-pr-2315 April 8, 2025 13:46 Inactive
@github-actions github-actions bot temporarily deployed to storybook-pr-2315 April 8, 2025 13:54 Inactive
@github-actions github-actions bot temporarily deployed to storybook-testing-pr-2315 April 8, 2025 13:54 Inactive
@github-actions github-actions bot temporarily deployed to storybook-pr-2315 April 8, 2025 14:30 Inactive
@github-actions github-actions bot temporarily deployed to storybook-testing-pr-2315 April 8, 2025 14:30 Inactive
@fernandofranca
Copy link
Contributor Author

/test-aperture

@pie-design-system-bot
Copy link
Contributor

Starting a new snapshot build. You can view the logs here.

@pie-design-system-bot
Copy link
Contributor

@fernandofranca Your snapshots have been published to npm!

Test the snapshots by updating your package.json with the newly-published versions:

Note

If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts.

yarn up @justeattakeaway/pie-cookie-banner@0.0.0-snapshot-release-20250408152752 --mode=update-lockfile
yarn up @justeattakeaway/pie-modal@0.0.0-snapshot-release-20250408152752 --mode=update-lockfile
yarn up @justeattakeaway/pie-webc@0.0.0-snapshot-release-20250408152752 --mode=update-lockfile

Then finally:

yarn install

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants