Skip to content

FE: Manual column width for Consumers and Topics tables #1273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

FE: Manual column width for Consumers and Topics tables #1273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions frontend/src/components/ConsumerGroups/List.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import { CONSUMER_GROUP_STATE_TOOLTIPS, PER_PAGE } from 'lib/constants';
import { useConsumerGroups } from 'lib/hooks/api/consumers';
import Tooltip from 'components/common/Tooltip/Tooltip';
import ResourcePageHeading from 'components/common/ResourcePageHeading/ResourcePageHeading';
import { useLocalStoragePersister } from 'components/common/NewTable/ColumnResizer/lib';

const List = () => {
const { clusterName } = useAppParams<ClusterNameRoute>();
Expand Down Expand Up @@ -47,6 +48,7 @@ const List = () => {
to={encodeURIComponent(`${getValue<string | number>()}`)}
/>
),
size: 600,
},
{
id: ConsumerGroupOrdering.MEMBERS,
Expand Down Expand Up @@ -96,6 +98,8 @@ const List = () => {
[]
);

const columnSizingPersister = useLocalStoragePersister('Consumers');

return (
<>
<ResourcePageHeading text="Consumers" />
Expand All @@ -118,6 +122,8 @@ const List = () => {
clusterConsumerGroupDetailsPath(clusterName, original.groupId)
)
}
enableColumnResizing
columnSizingPersister={columnSizingPersister}
disabled={consumerGroups.isFetching}
/>
</>
Expand Down
7 changes: 7 additions & 0 deletions frontend/src/components/Topics/List/TopicTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import { useSearchParams } from 'react-router-dom';
import ClusterContext from 'components/contexts/ClusterContext';
import { useTopics } from 'lib/hooks/api/topics';
import { PER_PAGE } from 'lib/constants';
import { useLocalStoragePersister } from 'components/common/NewTable/ColumnResizer/lib';

import { TopicTitleCell } from './TopicTitleCell';
import ActionsCell from './ActionsCell';
Expand Down Expand Up @@ -39,6 +40,7 @@ const TopicTable: React.FC = () => {
header: 'Topic Name',
accessorKey: 'name',
cell: TopicTitleCell,
size: 400,
meta: {
width: '100%',
},
Expand Down Expand Up @@ -70,6 +72,7 @@ const TopicTable: React.FC = () => {
accessorKey: 'replicationFactor',
enableSorting: false,
size: 148,
maxSize: 148,
},
{
header: 'Number of messages',
Expand Down Expand Up @@ -103,6 +106,8 @@ const TopicTable: React.FC = () => {
[]
);

const columnSizingPersister = useLocalStoragePersister('Topics');

return (
<Table
data={topics}
Expand All @@ -114,6 +119,8 @@ const TopicTable: React.FC = () => {
enableRowSelection={
!isReadOnly ? (row) => !row.original.internal : undefined
}
enableColumnResizing
columnSizingPersister={columnSizingPersister}
emptyMessage="No topics found"
/>
);
Expand Down
Loading