fix: make offscreen component able to change the offscreen distance #611
Conversation
commit: |
| if (!this.offscreenDistance && this.width && this.height) { | ||
| const selfRect = new Rect(pos, this.width, this.height); | ||
| return selfRect.collides(screenRect); | ||
| } | ||
| const sdist = Math.pow(this.offscreenDistance | ||
| ? this.offscreenDistance | ||
| : DEF_OFFSCREEN_DIS, 2); |
There was a problem hiding this comment.
This is not more complexity added?
There was a problem hiding this comment.
It only runs for when the offscreen distance is not set and it's a sprite() or rect() or text(), but considering that it allocates a new rect on each frame, I could probably fix that.
There was a problem hiding this comment.
Yeah, would be cool. It also adds a way for it working nice by default but I'm worried about that allocation.
There was a problem hiding this comment.
Do we really need to use pow? it's just
const sdist = this.offscreenDistance ?
this.offscreenDistance * this.offscreenDistance :
DEF_OFFSCREEN_DIS * DEF_OFFSCREEN_DIS;There was a problem hiding this comment.
But is that faster? If it isn't, I like the shorter solution
There was a problem hiding this comment.
Oof, your browser...
This is what I get (and In Firefox, nonetheless...):
There was a problem hiding this comment.
Guess it must be the processor then. Mine's an M3.
There was a problem hiding this comment.
Same on chrome on Mac OS X. No idea why a function call + various calculations gets the same speed as a multiplication on you PC.
if the object size is changed to be greater than the initially specified offscreen distance, then this allows the offscreen distance to be changed so it won't actually disappear until it goes offscreen. additionally the object will use whether its bounding rectangle is truly offscreen if the distance is not specified.