PST-777 Extract DataLoader #706
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepamartinec
force-pushed
the
pepa_PST-777_dind
branch
5 times, most recently
from
d77933b to
ffdb731
Compare
pepamartinec
commented
Apr 6, 2023
| /** @var string[] $warn */ | ||
| $warn = []; | ||
| /** @var string[] $info */ | ||
| $info = []; |
There was a problem hiding this comment.
PHPstan can't correctly infer types through references passed to the callback.
pepamartinec
commented
Apr 6, 2023
Comment on lines
+106
to
+108
| self::expectException(UserExceptionInterface::class); | ||
| self::expectExceptionMessage('Configuration ID not set'); | ||
| $dataLoader->storeOutput(); |
There was a problem hiding this comment.
Vyjimka se nove nevyhazuje uz v konstructoru, ale az pri spusteni OM.
pepamartinec
force-pushed
the
pepa_PST-777_dind
branch
4 times, most recently
from
2fe07cb to
832a598
Compare
pepamartinec
force-pushed
the
pepa_PST-777_dind
branch
from
832a598 to
3525ccd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://keboola.atlassian.net/browse/PST-777
Depends on https://github.com/keboola/job-queue/pull/258