Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New SolarWinds Observability Scaler #6577

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gantrior
Copy link

@gantrior gantrior commented Feb 28, 2025

Added SolarWinds Observability scaler

Checklist

Fixes #6576

PR to docs: kedacore/keda-docs#1545

TODOs:

  • Add E2E tests
  • Add PR to Docs

@gantrior gantrior changed the title feat: add solarwinds scaler New SolarWinds Observability Scaler Feb 28, 2025
@gantrior gantrior force-pushed the feat/solarwinds-scaler branch from b4db712 to e6ac597 Compare February 28, 2025 14:26
Signed-off-by: Tomas Panik <tomas.panik@solarwinds.com>
@gantrior gantrior force-pushed the feat/solarwinds-scaler branch from e6ac597 to 5c3a3a4 Compare March 3, 2025 08:28
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great adddition, just FYI we plan to ship a new KEDA release in coming days (in case you would like to have this feature in)

@gantrior
Copy link
Author

gantrior commented Mar 6, 2025

Great adddition, just FYI we plan to ship a new KEDA release in coming days (in case you would like to have this feature in)

I would be happy to ship it in the release, unfortunatelly at the moment I do not have time to complete E2E testing part. I will work out the remaining TODOs as soon as I can and properly verify it, It is ok to have it as part of the next release.

@zroubalik
Copy link
Member

Great adddition, just FYI we plan to ship a new KEDA release in coming days (in case you would like to have this feature in)

I would be happy to ship it in the release, unfortunatelly at the moment I do not have time to complete E2E testing part. I will work out the remaining TODOs as soon as I can and properly verify it, It is ok to have it as part of the next release.

Not a problem, I completely understand. (Un)fortunately we have a policy to not merge scalers without e2e tests coverage. If we don't hit this release, we can definitely merge it in the next one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support SolarWinds Scaler
2 participants