Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datasets): Added optuna.StudyDataset #1021

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

gtauzin
Copy link

@gtauzin gtauzin commented Feb 25, 2025

Description

Fixes #1019.

Development notes

  • Add optuna.StudyDataset

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Updated jsonschema/kedro-catalog-X.XX.json if necessary
  • Added a description of this change in the relevant RELEASE.md file
  • Added tests to cover my changes
  • Received approvals from at least half of the TSC (required for adding a new, non-experimental dataset)

@gtauzin gtauzin force-pushed the feature/optuna-study branch from 75faf87 to 59d361e Compare March 8, 2025 11:56
Signed-off-by: Guillaume Tauzin <4648633+gtauzin@users.noreply.github.com>
@gtauzin gtauzin force-pushed the feature/optuna-study branch from 59d361e to 45a80a4 Compare March 8, 2025 12:01
@gtauzin gtauzin marked this pull request as ready for review March 8, 2025 12:02
@gtauzin
Copy link
Author

gtauzin commented Mar 8, 2025

As the dataset is in kedro_dataset_experimental, the CI is not running the tests I wrote for optuna.StudyDataset but they all pass on my machine.

The CI is failing, but I am not sure it has anything to do with the changes I made. Also, locally following the contributing guide was tough. I could not install all the dependencies because of incompatibilities and the linting made change throughout the codebase of many unchanged files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optuna Study dataset
2 participants