Add safeguards to secure input on macOS #11928
Open
+8
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
droidmonkey
added
high priority 🚨
platform: macOS
pr: bugfix
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #11928 +/- ##
===========================================
- Coverage 63.92% 63.90% -0.03%
===========================================
Files 369 369
Lines 38920 38920
===========================================
- Hits 24878 24868 -10
- Misses 14042 14052 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
phoerious
reviewed
Mar 21, 2025
| if (enable) { | ||
| // Always keep the internal counter set to 1 |
There was a problem hiding this comment.
This is kind of arcane. There should be a more thorough explanation in the comment as to what this does and why it's needed.
There was a problem hiding this comment.
The api with macos is so bad. It keeps an internal counter that you have to decrement to zero to disable the feature. There is no way to determine the counter value. There is also no way to determine if your app (specifically) is still blocking.
There was a problem hiding this comment.
Put that in the comment and we're good. 😉
* Fixes #11906 * Disable secure input when password widget is hidden as well as focused out * Add safeguard to ensure the internal counter that macOS keeps is always set to 1 preventing the ability to disable secure input by focus/unfocus a password field
droidmonkey
force-pushed
the
fix/secure-input
branch
from
09d27d9 to
2a18b84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing strategy
Replicated issue on macOS and cannot replicate it after these changes.
Type of change