Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle private key decryption errors explicitly when sending assets #190

Conversation

kieranroneill
Copy link
Member

Description

  • Add a try catch around decrypting private key to catch "Invalid Password" errors when sending assts

Type of change

  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🏗️ Build configuration (CI configuration, scaffolding etc.)
  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • 📝 Documentation update(s)
  • 📦 Dependency update(s)
  • 👩🏽‍💻 Improve developer experience
  • ⚡ Improve performance
  • ✨ New feature (non-breaking change which adds functionality)
  • ♻ Refactor
  • ⏪ Revert changes
  • 🧪 New tests or updates to existing tests

@kieranroneill kieranroneill added the 🐛 bug Something isn't working label Feb 29, 2024
@kieranroneill kieranroneill self-assigned this Feb 29, 2024
@kieranroneill kieranroneill merged commit b58a1ab into beta Feb 29, 2024
8 checks passed
@kieranroneill kieranroneill deleted the 189-failed-transaction-error-instead-of-a-password-invalid-error-when-sending-assets branch February 29, 2024 21:11
github-actions bot pushed a commit that referenced this pull request Feb 29, 2024
## [1.12.1-beta.1](v1.12.0...v1.12.1-beta.1) (2024-02-29)

### Bug Fixes

* handle private key decryption errors explicitly when sending assets ([#190](#190)) ([b58a1ab](b58a1ab))
@agoralabs-bot
Copy link
Contributor

🎉 This PR is included in version 1.12.1-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@agoralabs-bot agoralabs-bot added the 🚀 released To the moon! label Feb 29, 2024
github-actions bot pushed a commit that referenced this pull request Mar 3, 2024
# [1.13.0](v1.12.1...v1.13.0) (2024-03-03)

### Bug Fixes

* handle private key decryption errors explicitly when sending assets ([#190](#190)) ([b58a1ab](b58a1ab))

### Features

* add page to export account via a qr code ([#196](#196)) ([29b4cb0](29b4cb0))
* add registration option to import an account via a qr code ([#195](#195)) ([fff684e](fff684e))
* view seed phrase for accounts ([#191](#191)) ([5beedac](5beedac))
@agoralabs-bot
Copy link
Contributor

🎉 This PR is included in version 1.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working 🚀 released To the moon!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Failed Transaction Error" instead of a password invalid error when sending assets
2 participants