Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set focus to new app window upon creation #202

Merged

Conversation

kieranroneill
Copy link
Member

refactor: move window creation to app window service
feat: set app window position to middle of current window

Description

  • Move window creation to AppWindowManagerService
  • Position app window to middle of current window on window creation [Chrome only]
  • Set focus to app window on creation

Type of change

  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🏗️ Build configuration (CI configuration, scaffolding etc.)
  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • 📝 Documentation update(s)
  • 📦 Dependency update(s)
  • 👩🏽‍💻 Improve developer experience
  • ⚡ Improve performance
  • ✨ New feature (non-breaking change which adds functionality)
  • ♻ Refactor
  • ⏪ Revert changes
  • 🧪 New tests or updates to existing tests

refactor: move window creation to app window service
feat: set app window position to middle of current window
@kieranroneill kieranroneill added ♻️ refactor The refactoring fairy has waved their magic wand ✨ feature New feature or request 🐛 bug Something isn't working labels Mar 8, 2024
@kieranroneill kieranroneill self-assigned this Mar 8, 2024
@kieranroneill kieranroneill linked an issue Mar 8, 2024 that may be closed by this pull request
@kieranroneill kieranroneill merged commit f7b7577 into beta Mar 8, 2024
8 checks passed
@kieranroneill kieranroneill deleted the 171-main-app-window-launches-behind-other-windows branch March 8, 2024 10:41
github-actions bot pushed a commit that referenced this pull request Mar 8, 2024
# [1.14.0-beta.4](v1.14.0-beta.3...v1.14.0-beta.4) (2024-03-08)

### Bug Fixes

* set focus to new app window upon creation ([#202](#202)) ([f7b7577](f7b7577))
@agoralabs-bot
Copy link
Contributor

🎉 This PR is included in version 1.14.0-beta.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@agoralabs-bot agoralabs-bot added the 🚀 released To the moon! label Mar 8, 2024
github-actions bot pushed a commit that referenced this pull request Mar 12, 2024
# [1.14.0](v1.13.0...v1.14.0) (2024-03-12)

### Bug Fixes

* set focus to new app window upon creation ([#202](#202)) ([f7b7577](f7b7577))

### Features

* display arc-0072 nft asset ([#198](#198)) ([2bb3d28](2bb3d28))
* dont allow adding of standard asset if account balance is below the minimum balance requirement ([#199](#199)) ([272a01a](272a01a))
* dont allow sending of assets if account is below the minimum balance ([#200](#200)) ([093db24](093db24))
* remove standard asset ([#203](#203)) ([7d7c258](7d7c258))
@agoralabs-bot
Copy link
Contributor

🎉 This PR is included in version 1.14.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working ✨ feature New feature or request ♻️ refactor The refactoring fairy has waved their magic wand 🚀 released To the moon!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Main app window launches behind other windows
2 participants