Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: quota bytes error no longer hit when large amounts of account #325

Merged
merged 17 commits into from
Sep 20, 2024
Merged

fix: quota bytes error no longer hit when large amounts of account #325

merged 17 commits into from
Sep 20, 2024

Conversation

kieranroneill
Copy link
Member

Description

  • Add unlimitedStorage permission to the manifest.
  • Move services that interact with storage to the new repository pattern.
  • Use higher level services to the new manager pattern.
  • Convert jest.config.js to jest.config.ts.
  • Fix the majority of linting warnings.
  • Save accounts and private keys in batches of 5.
  • Remove unused StorageManager and QuestsService.

Type of change

  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🏗️ Build configuration (CI configuration, scaffolding etc.)
  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • 📝 Documentation update(s)
  • 📦 Dependency update(s)
  • 👩🏽‍💻 Improve developer experience
  • ⚡ Improve performance
  • ✨ New feature (non-breaking change which adds functionality)
  • ♻ Refactor
  • ⏪ Revert changes
  • 🧪 New tests or updates to existing tests

@kieranroneill
fix: add unlimitedstorage permission
872a9fe
@kieranroneill
refactor: rename item storage type
4f38977
@kieranroneill
refactor: move account service to account repositiry service
784b23e
@kieranroneill
refactor: move session service to session repositiry service
868c261
@kieranroneill
refactor: move system service to system info repositiry service
90aeb77
@kieranroneill
refactor: separate app window to new managers and repositiries
d86e26d
@kieranroneill
chore: squash
1f25005
@kieranroneill
feat: add readme files to managers and repo dirs
f57e90b
@kieranroneill
refactor: separate passkey/password to repos and managers and move pr…
0e73eab 
…ivate key to repo
@kieranroneill
refactor: move asset services to repo pattern
db9741d
@kieranroneill
refactor: move settings and networks to repo patterns
a2694a9
@kieranroneill
refactor: move event queue to repo pattern
ae53d15
@kieranroneill
refactor: remove storage manager and quests service
ccb600b
@kieranroneill
build: use typescript for jest config
9b5790f
@kieranroneill
chore: fix lint warniings
6cab64d
@kieranroneill
feat: save accounts and private keys in batrches
63b8347
@kieranroneill
chore: squash
3851a9e
@kieranroneill kieranroneill added ♻️ refactor The refactoring fairy has waved their magic wand 🐛 bug Something isn't working labels Sep 20, 2024
@kieranroneill kieranroneill self-assigned this Sep 20, 2024
@kieranroneill kieranroneill linked an issue Sep 20, 2024 that may be closed by this pull request
A lot of accounts are causing an "QUOTA_BYTES" error #324
Closed
@kieranroneill kieranroneill merged commit ba63dda into beta Sep 20, 2024
9 checks passed
@kieranroneill kieranroneill deleted the 324-a-lot-of-accounts-are-causing-an-quota_bytes-error branch September 20, 2024 18:09
github-actions bot pushed a commit that referenced this pull request Sep 20, 2024
@agoralabs-bot
chore(release): 2.1.1-beta.1
a2b58b1 
## [2.1.1-beta.1](v2.1.0...v2.1.1-beta.1) (2024-09-20)

### Bug Fixes

* quota bytes error no longer hit when large amounts of account ([#325](#325)) ([ba63dda](ba63dda))
@agoralabs-bot
Copy link
Contributor

🎉 This issue has been resolved in version 2.1.1-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@agoralabs-bot agoralabs-bot added the 🚀 released To the moon! label Sep 20, 2024
github-actions bot pushed a commit that referenced this pull request Sep 22, 2024
@agoralabs-bot
chore(release): 2.2.0
ddea539 
# [2.2.0](v2.1.0...v2.2.0) (2024-09-22)

### Bug Fixes

* quota bytes error no longer hit when large amounts of account ([#325](#325)) ([ba63dda](ba63dda))

### Features

* add primary account ([#329](#329)) ([65cc8de](65cc8de))
* reorder accounts in the sidebar ([#327](#327)) ([1c50003](1c50003))
@agoralabs-bot
Copy link
Contributor

🎉 This issue has been resolved in version 2.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kieranroneill kieranroneill

Labels
🐛 bug Something isn't working ♻️ refactor The refactoring fairy has waved their magic wand 🚀 released To the moon!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A lot of accounts are causing an "QUOTA_BYTES" error
2 participants
@kieranroneill @agoralabs-bot