Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: change label_selector from string to dict #4

Merged
merged 1 commit into from
Jun 29, 2024

Conversation

kimdre
Copy link
Owner

@kimdre kimdre commented Jun 29, 2024

Breaking Change

This changes the label_selector variable type from string to dictionary to simplify managing the labels to search/filter for on rotation.

Example

Before:

label_selector: "created_by=ansible.hcloud-backup,host={{ inventory_hostname }}"

Now:

label_selector:
  created_by: ansible.hcloud-backup
  host: "{{ inventory_hostname }}"

@kimdre kimdre added Kind/Breaking Breaking change that won't be backward compatible Kind/Enhancement Improve existing functionallity labels Jun 29, 2024
@kimdre kimdre self-assigned this Jun 29, 2024
@kimdre kimdre merged commit 1b46839 into main Jun 29, 2024
1 check passed
@kimdre kimdre deleted the fix/change-label-selector branch June 29, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Kind/Breaking Breaking change that won't be backward compatible Kind/Enhancement Improve existing functionallity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant