Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: for Erlang/OTP 27 #5

Merged
merged 2 commits into from
Jun 27, 2024
Merged

fix: for Erlang/OTP 27 #5

merged 2 commits into from
Jun 27, 2024

Conversation

kivra-pauoli
Copy link

Motivation

We're starting to test some of our tools in OTP 27. This is a step in that direction.

Description

The fixed issue comes from erlang/otp#8069.

Further considerations

The proposal for change (coverage for lib. tests below) comes from WhatsApp/erlfmt#354 (mentioned in that same issue).

Note: we could've not be using a macro for this, but I wanted a small change scope.

Coverage

module          coverage %
crontab         100%
crontab_app     100%
crontab_server  90%
crontab_sup     100%
crontab_time    100%
Total           96%

@kivra-pauoli
Copy link
Author

Reviewers were chosen as per recent history (you touched this the last time 😄).

Copy link

@kivra-fabber kivra-fabber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kivra-pauoli kivra-pauoli merged commit da00ca0 into master Jun 27, 2024
6 checks passed
@kivra-pauoli kivra-pauoli deleted the fix/for-otp27 branch June 27, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants