-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add div mod hint #127
Conversation
Update 📌Hi @zmalatrax
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great :)
About the integration test, you need to add a Cairo program It should be a simple program focused on this hint, such as fn main() {
let _ = 17_u32 / 12_u32;
let _ = 17_u32 % 12_u32;
} |
Hi @zmalatrax I was able to solve some problems running the integration test haha, it took me a while but I got it done, unit test and integration test ready plus the feedback given, as you can see below it is working so I will open this draft PR to "Ready for review" 🫡 |
Hi @zmalatrax I already changed the condition as you said and @enitrat I added a new edge case test, if you need something else to be improved just tell me, thanks 🫡 |
Hi @zmalatrax I applied the changes and add a few more tests ✅ |
Hi @zmalatrax, I already applied the improvement, thanks 🫡 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good
Hi @zmalatrax,
I've made significant progress on the
DivMod
hint implementation, including updates to thehintName.ts
,hintSchema.ts
,hintHandler.ts
. The core logic is nearly complete, but a few final adjustments are still needed indivMod.ts
. Also, theverified
tag is working according with the contribution guidelines.Status