Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: load macro #547

Merged
merged 26 commits into from
Oct 18, 2023
Merged

test: load macro #547

merged 26 commits into from
Oct 18, 2023

Conversation

greged93
Copy link
Contributor

Pull Request type

Time spent on this PR: 3 days

Resolves: #545

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Testing

What is the new behavior?

Instead of running one test per ef-tests folder (hence about 60 tests), we now run one tests per test subcase of each file (hence +19k tests). Tests that are skipped are also marked as ignored, which allows for better tracking of the skipped tests.

Does this introduce a breaking change?

  • Yes
  • No

Eikix
Eikix reviewed Oct 17, 2023
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
Eikix
Eikix reviewed Oct 17, 2023
View reviewed changes
Makefile Show resolved Hide resolved
ClementWalter
ClementWalter requested changes Oct 18, 2023
View reviewed changes
Copy link
Member

@ClementWalter ClementWalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just need to make sure that a change in blockchain-tests-skip.yml will be seen by the compiler, and regenerate the tests accordingly

greged93 added 22 commits October 18, 2023 12:21
ClementWalter
ClementWalter previously approved these changes Oct 18, 2023
View reviewed changes
@greged93 greged93 added this pull request to the merge queue Oct 18, 2023
Merged via the queue into kkrt-labs:main with commit acf81fe Oct 18, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eikix Eikix Eikix left review comments

@ClementWalter ClementWalter ClementWalter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@greged93 @ClementWalter @Eikix