Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add coinbase base fee #652

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

greged93
Copy link
Contributor

@greged93 greged93 commented Feb 6, 2024

Pull Request type

Time spent on this PR: 0.2 day

Resolves: #650

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Testing

What is the new behavior?

Sets the coinbase address and the base fee in the storage of Kakarot v0.

Does this introduce a breaking change?

  • Yes
  • No

This change is Reviewable

@greged93 greged93 force-pushed the feat/add-coinbase-base-fee branch from b03bb13 to 8ad73d4 Compare February 6, 2024 14:13
@Eikix
Copy link
Member

Eikix commented Feb 6, 2024

this PR supersedes the previous one, should I close the one before?

@greged93
Copy link
Contributor Author

greged93 commented Feb 6, 2024

No no, we can merge the other first and I will rebase

@greged93 greged93 force-pushed the feat/add-coinbase-base-fee branch from 8ad73d4 to cd3ee04 Compare February 6, 2024 16:16
@ClementWalter ClementWalter added this pull request to the merge queue Feb 6, 2024
Merged via the queue into kkrt-labs:main with commit 2aa521d Feb 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: set coinbase and block_base_fee in storage vars of kakarot
3 participants