Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: skip nonce increment when eth validation failed in __execute__ #653

Merged
merged 6 commits into from
Feb 8, 2024

Conversation

enitrat
Copy link
Contributor

@enitrat enitrat commented Feb 7, 2024

Pull Request type

Time spent on this PR:

Resolves: #{Issue number}

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Testing

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

This change is Reviewable

@enitrat enitrat changed the title fit: skip nonce increment when eth validation failed in __execute__ feat: skip nonce increment when eth validation failed in __execute__ Feb 7, 2024
crates/ef-testing/src/models/case.rs Outdated Show resolved Hide resolved
crates/ef-testing/src/models/case.rs Outdated Show resolved Hide resolved
crates/ef-testing/src/models/result.rs Outdated Show resolved Hide resolved
crates/ef-testing/src/models/result.rs Outdated Show resolved Hide resolved
crates/ef-testing/src/models/result.rs Outdated Show resolved Hide resolved
crates/ef-testing/src/models/result.rs Show resolved Hide resolved
crates/ef-testing/src/models/result.rs Show resolved Hide resolved
enitrat and others added 2 commits February 7, 2024 18:13
Co-authored-by: greged93 <82421016+greged93@users.noreply.github.com>
@enitrat enitrat force-pushed the feat/skip-validation-failed-nonce-increment branch from 49883bc to 69d4c7b Compare February 7, 2024 19:34
@enitrat enitrat force-pushed the feat/skip-validation-failed-nonce-increment branch from 69d4c7b to d38028e Compare February 8, 2024 09:17
@greged93 greged93 added this pull request to the merge queue Feb 8, 2024
Merged via the queue into main with commit 6ff2e84 Feb 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants