feat: execute from outside #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcoratger
reviewed
Jul 13, 2024
obatirou
force-pushed
the
oba/execute-from-outside-ef-tests
branch
from
6c95695 to
9f99151
Compare
Co-authored-by: Thomas Coratger <60488569+tcoratger@users.noreply.github.com>
success was always false due to its default value
enitrat
force-pushed
the
oba/execute-from-outside-ef-tests
branch
from
d98d40a to
7619be8
Compare
|
IIRC this was pending the next release to be mergeable, should be good now |
enitrat
approved these changes
Jul 22, 2024
|
so we can merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Time spent on this PR:
Resolves: #{Issue number}
Please check the type of change your PR introduces:
What is the new behavior?
The main entrypoint of kakarot accounts is now
execute_from_outsideDoes this introduce a breaking change?