This repository has been archived by the owner on Jan 8, 2025. It is now read-only.
feat: execute #430
Merged
feat: execute #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eikix
reviewed
Oct 18, 2023
Eikix
reviewed
Oct 18, 2023
Eikix
reviewed
Oct 18, 2023
Eikix
reviewed
Oct 18, 2023
Eikix
reviewed
Oct 18, 2023
Eikix
reviewed
Oct 18, 2023
Should we? I think it should be part of a bigger testing strategy. Or should I just send an empty bytecode? |
I see, may make more sense to test interpreter.run then |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Please check the type of change your PR introduces:
What is the current behavior?
Resolves: #424
What is the new behavior?
starknet_addressfield from the contextexecutefunctionexecution::executefunction that the core contract will call #424Does this introduce a breaking change?