This repository has been archived by the owner on Jan 9, 2025. It is now read-only.
Add casting utils #840
Merged
Add casting utils #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #840 +/- ##
==========================================
+ Coverage 71.61% 72.41% +0.79%
==========================================
Files 49 49
Lines 6116 6043 -73
==========================================
- Hits 4380 4376 -4
+ Misses 1736 1667 -69 ☔ View full report in Codecov by Sentry. |
Eikix
reviewed
Dec 5, 2023
ClementWalter
force-pushed
the
cw/casting-utils
branch
from
9ac4691 to
1f76a28
Compare
ClementWalter
force-pushed
the
cw/casting-utils
branch
2 times, most recently
from
aaf6d17 to
1f76a28
Compare
Merged
ClementWalter
added a commit
that referenced
this pull request
Dec 5, 2023
Following partial #840 merged after CI went ✅
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time spent on this PR: 2
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Some casting utils in
utils.utils.Helpers, sometimes redundant, sometimes with non consistant naming, sometime very expensive.Resolves #835
What is the new behavior?
New utils in dedicated files with EVM consistent naming and signature.