Secp256k1 Cost annihilation #291
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const POW_2_96 = 2 ** 96; | ||
|
|
||
| @known_ap_change | ||
| func get_generator_point() -> (point: G1Point) { |
There was a problem hiding this comment.
could use a label
g1_point:
dw 0x2dce28d959f2815b16f81798
dw 0x55a06295ce870b07029bfcdb
dw 0x79be667ef9dcbbac
dw 0x0
dw 0xa68554199c47d08ffb10d4b8
dw 0x5da4fbfc0e1108a8fd17b448
dw 0x483ada7726a3c465
dw 0x0
and save the 8 steps to write `ret` data each call
| } | ||
|
|
||
| @known_ap_change | ||
| func sign_to_UInt384_mod_secp256k1(sign: felt) -> (res: UInt384) { |
There was a problem hiding this comment.
codebase specific, but return just the type, no need to make it a tuple (apply to all functions)
| } | ||
|
|
||
| // Assume the input is valid UInt384 (will be the case if coming from ModuloBuiltin) | ||
| func uint384_to_uint256_mod_p{range_check_ptr}(a: UInt384, p: UInt384) -> (res: Uint256) { |
There was a problem hiding this comment.
isn't there any missing constraints on P here?
|
why this @Eikix |
i dont remember doing this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
signature verification costs divided by 25x