feat: rust vm hints #412
Merged
feat: rust vm hints #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enitrat
force-pushed
the
feat/rust-vm-hints
branch
from
4134980 to
8876982
Compare
enitrat
force-pushed
the
feat/rust-vm-hints
branch
2 times, most recently
from
8069a95 to
e629b46
Compare
obatirou
reviewed
Jan 14, 2025
obatirou
reviewed
Jan 14, 2025
obatirou
reviewed
Jan 14, 2025
obatirou
reviewed
Jan 14, 2025
obatirou
reviewed
Jan 14, 2025
obatirou
reviewed
Jan 14, 2025
obatirou
reviewed
Jan 14, 2025
obatirou
reviewed
Jan 14, 2025
enitrat
force-pushed
the
feat/rust-vm-hints
branch
from
6d3b961 to
0494085
Compare
enitrat
force-pushed
the
feat/rust-vm-hints
branch
2 times, most recently
from
4079651 to
91d2d79
Compare
enitrat
force-pushed
the
feat/rust-vm-hints
branch
from
26f6ba7 to
17e896e
Compare
| @@ -103,11 +88,14 @@ def test_nibble_list_to_compact_should_raise_when_wrong_remainder( | |||
| ), | |||
| cairo_error(message="nibble_list_to_compact: invalid remainder"), | |||
| ): | |||
| cairo_run("nibble_list_to_compact", x, is_leaf) | |||
| # Always run patch_hint tests with the python VM | |||
There was a problem hiding this comment.
we need to think about a solution for this for ok for now
There was a problem hiding this comment.
note: one could put all the imports at the module level and no imports in the hints because the whole module is loaded so they would be available at runtime, but I think that it's also good to keep the module imports at the minimum required to define a hint
ClementWalter
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds most common hints to run the tests in the Rust VM.