feat: increment nonce #467
Merged
+22
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Setting to draft to add a check to the nonce, we don't want it to wrap around the prime field but rather error out if it's larger than the max allowed nonce, which seems to be u64.max() in other EVM impls. |
Eikix
force-pushed
the
feat/increment_nonce
branch
from
8129ac2 to
b7c097b
Compare
Eikix
force-pushed
the
feat/increment_nonce
branch
from
b7c097b to
2ff10d8
Compare
|
@Eikix I don't understand the comment: what's the blocker? The current version looks good to me. |
Comment is out of date, it was before we talked about the validate_transaction |
enitrat
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #454