feat: blob_hash #489
Open
feat: blob_hash #489
+91
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eikix
reviewed
Jan 17, 2025
|
|
||
| // If index is within bounds, get the hash at that index | ||
| // Otherwise return zero bytes | ||
| let (high, low) = split_felt(blob_hashes.value.len); |
There was a problem hiding this comment.
i guess it's fine to do this because we don't want to over analyze the evm
but blob_hashes.value.len right now is between 2 and 5, in the future it'll be at most 200 or maybe 1000
Eikix
reviewed
Jan 17, 2025
| if (out_of_bounds.value == 0) { | ||
| tempvar blob_hash = Bytes32(new Bytes32Struct(0, 0)); | ||
| } else { | ||
| tempvar blob_hash = blob_hashes.value.data[index.value.low]; |
There was a problem hiding this comment.
if we're only using index.value.low, we should probably assert index.value.high == 0, as well as blob_hashes.value.len.high ==0,
then just compare the two low felt values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #479