Safe wallet #1
Open
Safe wallet #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Some spelling mistakes in this file could mislead people who read it, and spelling errors in the code could affect the program file.
Resolves #
Modifications in .github/workflows/deploy-dev.yml to improve the handling of branch names.
Updates in cypress/e2e/happypath/tx_history_filter_hp_1.cy.js to skip flaky tests.
Fix in cypress/e2e/pages/create_tx.pages.js where an incorrect variable name (expande-all-btn) was corrected to expand-all-btn.
How this PR fixes it
deploy-dev.yml: The branch name extraction logic is updated to ensure the correct format is applied (alphanumeric characters, lowercase, and underscore replacements for non-alphanumeric characters).
tx_history_filter_hp_1.cy.js: Skips the flaky test with a describe.skip() to avoid failures until resolved.
create_tx.pages.js: Corrects a typo where expande-all-btn is changed to expand-all-btn to prevent issues during test execution.
How to test it
For .github/workflows/deploy-dev.yml, check if the branch name is correctly extracted and formatted in the workflow logs.
For cypress/e2e/happypath/tx_history_filter_hp_1.cy.js, ensure that the flaky test is skipped during test runs.
For cypress/e2e/pages/create_tx.pages.js, verify that the issue with the button ID is resolved and the test runs successfully.
Screenshots
Checklist