Fix: contract function params, redeployed #69
Conversation
WalkthroughThe recent updates focus on three main areas: simplifying the Changes
Poem
[((\ ( -.- ) ))] Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
✅ Deploy Preview for kleros-escrow-v2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jaybuidl
force-pushed
the
chore/update-mappings-in-create-transaction-flow
branch
from
b246d3e to
370ea64
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (5)
- contracts/README.md (1 hunks)
- contracts/src/EscrowUniversal.sol (2 hunks)
- contracts/src/interfaces/IEscrow.sol (2 hunks)
- subgraph/package.json (1 hunks)
- subgraph/subgraph.yaml (1 hunks)
Files skipped from review due to trivial changes (3)
- contracts/src/EscrowUniversal.sol
- subgraph/package.json
- subgraph/subgraph.yaml
Additional context used
LanguageTool
contracts/README.md
[uncategorized] ~69-~69: Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION)
Context: ... env vars are required: -PRIVATE_KEY: the private key of the deployer account...
[uncategorized] ~70-~70: Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION)
Context: ...or the testnets. -MAINNET_PRIVATE_KEY: the private key of the deployer account...
[uncategorized] ~71-~71: Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION)
Context: ...unt used for Mainnet. -INFURA_API_KEY: the API key for infura. The ones below...
[uncategorized] ~75-~75: Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION)
Context: ...low are optional: -ETHERSCAN_API_KEY: to verify the source of the newly deplo...
[uncategorized] ~76-~76: Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION)
Context: ...s on Etherscan. -ARBISCAN_API_KEY: to verify the source of the newly deplo...
[uncategorized] ~77-~77: Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION)
Context: ... on Arbitrum. -GNOSISSCAN_API_KEY: to verify the source of the newly deplo...
[uncategorized] ~81-~81: Use a comma before ‘so’ if it connects two independent clauses (unless they are closely connected and short). (COMMA_COMPOUND_SENTENCE_2)
Context: ...ed for the kleros-v2 contracts currently so this would fail. For now consider deplo...
[typographical] ~81-~81: Consider adding a comma here. (FOR_NOW_COMMA)
Context: ...contracts currently so this would fail. For now consider deploying to a testnet fork (n...
[grammar] ~89-~89: The word ‘deploy’ is a verb. Did you mean the noun “deployment” (= release, placement)? (PREPOSITION_VERB)
Context: ...node --tags nothing**Shell 2: the deploy script**bash yarn deploy --network...
[grammar] ~105-~105: The word ‘deploy’ is a verb. Did you mean the noun “deployment” (= release, placement)? (PREPOSITION_VERB)
Context: ... start-testnet-fork**Shell 2: the deploy script**bash yarn deploy-devnet-fo...
Markdownlint
contracts/README.md
12-12: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
15-15: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
9-9: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
10-10: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
16-16: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
17-17: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
83-83: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
89-89: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
97-97: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
105-105: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
127-127: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
133-133: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
Additional comments not posted (2)
contracts/README.md (1)
19-19: Updated EscrowUniversal address is correct.The updated link correctly points to the new address on the Arbitrum Sepolia blockchain explorer. This change is crucial for users to access the correct contract information.
contracts/src/interfaces/IEscrow.sol (1)
84-84: SimplifiedcreateNativeTransactionfunction signature.The removal of
_templateDataand_templateDataMappingsparameters simplifies the function signature. Ensure that all implementations and calls to this function across the project have been updated to match this new signature.Verification successful
Simplified
createNativeTransactionfunction signature verified.The function signature for
createNativeTransactionhas been updated to remove the_templateDataand_templateDataMappingsparameters. The new signature is correctly reflected in the following files:
contracts/src/EscrowUniversal.solcontracts/src/interfaces/IEscrow.solScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all calls to `createNativeTransaction` use the new signature. # Test: Search for the function usage. Expect: Only occurances of the new signature. ast-grep --lang solidity --pattern $'interface IEscrow { $$$ function createNativeTransaction($_, $_, $_) { $$$ } $$$ }'Length of output: 238
Script:
#!/bin/bash # Description: Verify all calls to `createNativeTransaction` use the new signature. # Search for function definitions and calls to `createNativeTransaction` in Solidity files rg -t solidity 'createNativeTransaction'Length of output: 73
Script:
#!/bin/bash # Description: Verify all calls to `createNativeTransaction` use the new signature. # Search for all occurrences of `createNativeTransaction` in the codebase rg 'createNativeTransaction'Length of output: 74710
PR-Codex overview
The PR updates the version, contract addresses, and start block number for the Arbitrum Sepolia subgraph. It also refactors the EscrowUniversal contract by removing unnecessary parameters.
Detailed summary
package.jsonSummary by CodeRabbit
New Features
EscrowUniversalunderArbitrum Sepoliain documentation.Changes
createNativeTransactionandcreateERC20Transactionby removing unnecessary parameters.EscrowUniversaldata source address and start block value insubgraph.yaml.Versioning
@kleros/escrow-v2-subgraphfrom2.0.4to2.0.6.