Skip to content

fix open resolve #750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Conversation

TimWhiting
Copy link
Collaborator

@TimWhiting TimWhiting commented Jul 13, 2025

This fixes the open-resolve issue, and illustrates the problem, but likely introduces unnecessary inefficiencies.

One potential solution might be to leave the effect row as is and set a flag which is checked when inserting a new handler, such that the handler inserts itself into a fresh row if it should be empty.

Although this fixes the examples I have such as #743, I'm marking it as draft because I assume the performance penalty is not worth it.

@TimWhiting TimWhiting marked this pull request as ready for review July 16, 2025 01:06
@TimWhiting TimWhiting force-pushed the dev branch 3 times, most recently from 2c83d90 to 00399ab Compare August 13, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant