Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 make analysis runs cancellable #139

Merged
merged 4 commits into from
Dec 11, 2024
Merged

🐛 make analysis runs cancellable #139

merged 4 commits into from
Dec 11, 2024

Conversation

djzager
Copy link
Member

@djzager djzager commented Dec 6, 2024

Fixes #131

@djzager djzager requested a review from a team as a code owner December 6, 2024 16:48
@djzager
🐛 make analysis runs cancellable
373471d 
Signed-off-by: David Zager <dzager@redhat.com>
@djzager djzager requested a review from rszwajko December 6, 2024 20:05
@rszwajko
Resolve cancellation promise
89f489d 
Signed-off-by: Radoslaw Szwajkowski <rszwajko@redhat.com>
@rszwajko
Merge branch 'main' into cancel-analysis
9b29639
sjd78
sjd78 approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So technically the analysis process won't actually get cancelled, but the UI will be unblocked.

Good enough for now.

@rszwajko rszwajko merged commit fb9f899 into konveyor:main Dec 11, 2024
9 checks passed
@sjd78 sjd78 mentioned this pull request Dec 11, 2024
Open
@sjd78
Copy link
Member

sjd78 commented Dec 11, 2024

Note: See #149

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rszwajko rszwajko rszwajko left review comments

@ibolton336 ibolton336 ibolton336 approved these changes

@sjd78 sjd78 sjd78 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

User should be able to cancel an analysis
4 participants
@djzager @sjd78 @ibolton336 @rszwajko