Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 adding changelog func #86

Merged
merged 9 commits into from
Nov 18, 2024
Merged

🌱 adding changelog func #86

merged 9 commits into from
Nov 18, 2024
+22 −11

Conversation

savitharaghunathan
Copy link
Member

Added changelog functionality

updated the steps to match ci-repo workflow steps

wait for konveyor/release-tools#96 to merge

@savitharaghunathan
adding changelog func
c9081e9 
Signed-off-by: Savitha Raghunathan <saveetha13@gmail.com>
@savitharaghunathan savitharaghunathan mentioned this pull request Oct 30, 2024
Closed
@savitharaghunathan savitharaghunathan self-assigned this Oct 30, 2024
@savitharaghunathan
update chnagelog gen
4b8a969 
Signed-off-by: Savitha Raghunathan <saveetha13@gmail.com>
@savitharaghunathan savitharaghunathan mentioned this pull request Nov 1, 2024
Merged
savitharaghunathan and others added 4 commits November 4, 2024 14:56
@savitharaghunathan
updates to changelog gen
54afb5f 
Signed-off-by: Savitha Raghunathan <saveetha13@gmail.com>
@savitharaghunathan
revert updates to changelog gen
a4545fd 
Signed-off-by: Savitha Raghunathan <saveetha13@gmail.com>
@savitharaghunathan
revert updates to changelog gen
679f17c 
Signed-off-by: Savitha Raghunathan <saveetha13@gmail.com>
@djzager
Merge branch 'main' into add_changelog
b3d44e3 
Signed-off-by: David Zager <dzager@redhat.com>
djzager
djzager previously approved these changes Nov 12, 2024
View reviewed changes
@djzager djzager requested a review from a team November 12, 2024 18:29
rszwajko
rszwajko reviewed Nov 12, 2024
View reviewed changes
Copy link
Contributor

@rszwajko rszwajko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some places left with ./vscode working directory - check my comments below:

.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Show resolved Hide resolved
@sjd78 sjd78 requested a review from a team as a code owner November 15, 2024 00:19
sjd78
sjd78 requested changes Nov 15, 2024
View reviewed changes
Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working directory for the linux testing probably isn't needed

.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Show resolved Hide resolved
savitharaghunathan and others added 2 commits November 18, 2024 10:51
@savitharaghunathan
Merge branch 'konveyor:main' into add_changelog
b9b4bc9
@savitharaghunathan
review feedback
0d777de 
Signed-off-by: Savitha Raghunathan <saveetha13@gmail.com>
sjd78
sjd78 approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjd78 sjd78 merged commit 7507043 into konveyor:main Nov 18, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjd78 sjd78 sjd78 approved these changes

@rszwajko rszwajko Awaiting requested review from rszwajko

@djzager djzager Awaiting requested review from djzager

Assignees

@savitharaghunathan savitharaghunathan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@savitharaghunathan @djzager @sjd78 @rszwajko