Fix technology usage messages #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmle
force-pushed
the
fix-technology-usage-messages
branch
from
a4558e4 to
8ba4bf4
Compare
Signed-off-by: Juan Manuel Leflet Estrada <jleflete@redhat.com>
jmle
force-pushed
the
fix-technology-usage-messages
branch
from
8ba4bf4 to
44197ba
Compare
|
IIUC, this is fixing the case when technology rules are supposed to be just for tagging, but they have a message so now we are also getting violations that we should not. Is this correct? |
shawn-hurley
approved these changes
Feb 19, 2024
|
@shawn-hurley that's correct. Some rules were left out... I think this should cover all. |
|
@pranavgaikwad you are out on PTO, going to merge this now and if there is something way off just revert when you get back |
pranavgaikwad
pushed a commit
to pranavgaikwad/rulesets
that referenced
this pull request
Feb 20, 2024
Signed-off-by: Juan Manuel Leflet Estrada <jleflete@redhat.com>
jmle
added a commit
that referenced
this pull request
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.