Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Detected and report better errors. #42

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jortel
Copy link
Contributor

@jortel jortel commented Oct 10, 2023

Detected and report better errors by pattern matching in command output. This provides the most benefit for commands like Maven the bury errors in a ton of output. Or, as in git output has cryptic output when using the trust store and credentials not associated.
Another part of this COULD be: To potentially taking another approach to Git and SVN credentials. To pass them on the command line instead of the more complicated approach used currently. The masking is needed to support this.
For example (git):

https://github.com/konveyor/tackle-testapp.git

Would be:

https://user:password@github.com/konveyor/tackle-testapp.git

and masked when reported in Task.Activity as:

https://####:####@github.com/konveyor/tackle-testapp.git

This is simpler than setting up the git credentials store and would likely yield better errors.


This PR will support reporting better Auth errors but I'm not convinced it's worth it because with exception of the Git "Host not found .." cryptic error, all other errors are easily understood from the command output in the Task.Activity.

jortel added 3 commits October 9, 2023 14:05
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant