✨ Add confidence and risk to Application and Archetype resources.
#530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mansam
commented
Oct 18, 2023
| @@ -1112,13 +1069,15 @@ type Application struct { | |||
| Comments string `json:"comments"` | |||
| Identities []Ref `json:"identities"` | |||
| Tags []TagRef `json:"tags"` | |||
| BusinessService *Ref `json:"businessService"` | |||
| BusinessService *Ref `json:"businessService" yaml:"businessService"` | |||
There was a problem hiding this comment.
Did these for the Application resource while I was here, still need to do a comprehensive sweep in another PR.
mansam
changed the title
confidence and risk to Application and Archetype resources.confidence and risk to Application and Archetype resources.
Signed-off-by: Sam Lucidi <slucidi@redhat.com>
mansam
force-pushed
the
improved-assessment-status
branch
from
8ced42d to
4f4cd47
Compare
Signed-off-by: Sam Lucidi <slucidi@redhat.com>
mansam
force-pushed
the
improved-assessment-status
branch
from
4f4cd47 to
812f4a0
Compare
aufi
added a commit
to aufi/go-konveyor-tests
that referenced
this pull request
Oct 20, 2023
There was a change in review API adding new fields, updating Hub dependency. Related to konveyor/tackle2-hub#530 Signed-off-by: Marek Aufart <maufart@redhat.com>
aufi
pushed a commit
to aufi/tackle2-hub
that referenced
this pull request
Oct 30, 2023
…konveyor#530) * Add `confidence` and `risk` fields to Application and Archetype resources. Overall confidence calculated using the algorithm from Pathfinder for each assessment, then summed and divided by total number of assessments. Overall risk level is `green` if all assessments are `green`, otherwise the overall risk is `red`, `unknown`, or `yellow` in that priority order if any assessments have that risk level. * Moved some assessment status logic out of the resource and into the assessment package where it belongs. * Added ArchetypeResolver to better encapsulate the related behaviors and for symmetry with ApplicationResolver. * Simplified the Application and Archetype endpoints by replacing several related resource `With*` methods with `WithResolver`. * Improved consistency of the APIs within the `assessment` package. --------- Signed-off-by: Sam Lucidi <slucidi@redhat.com>
This was referenced Nov 22, 2023
mguetta1
pushed a commit
to mguetta1/go-konveyor-tests
that referenced
this pull request
Dec 5, 2023
There was a change in review API adding new fields, updating Hub dependency. Related to konveyor/tackle2-hub#530 Signed-off-by: Marek Aufart <maufart@redhat.com>
aufi
added a commit
to konveyor/go-konveyor-tests
that referenced
this pull request
Dec 13, 2023
There was a change in review API adding new fields, updating Hub dependency. Related to konveyor/tackle2-hub#530 Signed-off-by: Marek Aufart <maufart@redhat.com>
This was referenced Jan 23, 2024
mguetta1
pushed a commit
to mguetta1/go-konveyor-tests
that referenced
this pull request
Jan 31, 2024
There was a change in review API adding new fields, updating Hub dependency. Related to konveyor/tackle2-hub#530 Signed-off-by: Marek Aufart <maufart@redhat.com> Signed-off-by: Maayan Hadasi <mguetta@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
confidenceandriskfields to Application and Archetype resources. Overall confidence calculated using the algorithm from Pathfinder for each assessment, then summed and divided by total number of assessments. Overall risk level isgreenif all assessments aregreen, otherwise the overall risk isred,unknown, oryellowin that priority order if any assessments have that risk level.With*methods withWithResolver.assessmentpackage.