Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Cherry picks to release-0.6 for hub SCC fixes #765

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

dymurray
Copy link
Contributor

No description provided.

Signed-off-by: Jason Montleon <jmontleo@redhat.com>
(cherry picked from commit 12a28b8)
It looks like running as root is failing on minikube (and probably
vanilla kubernetes) because there is no /etc/passwd entry to correspond
to the UID. This is the source of the current test failures.

golang/go#38599

In a minikube environment the operator runs as UID 1001 and assigns this
to the hub as well.

My thoughts on this were that we could:
- Add a /etc/passwd for uid 1001 to cover the default vanilla
kube/minikube scenario
- Check in the operator if the operators uid is 1001 and if so set the
hub_uid to 0 instead, which I guess mimics the current status quo.
- Find a different way to get the UID in go... (no luck so far and I'd
guess if there were an option it would have been mentioned on the issue
linked above).

@jortel  also mentioned we could:
- Have the hub exec and run id -u instead of os.user.Current().
- If the ansible module in the operator has access to the real uid, it
can set the "TASK_UID" env var.

I am happy to rework this however we want.

Signed-off-by: Jason Montleon <jmontleo@redhat.com>
(cherry picked from commit a4c11db)
@dymurray dymurray changed the title Cherry picks to release-0.6 for hub SCC fixes 🐛 Cherry picks to release-0.6 for hub SCC fixes Nov 20, 2024
Copy link
Contributor

@jortel jortel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jmontleon jmontleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK / LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants