-
Notifications
You must be signed in to change notification settings - Fork 52
Best practice: GPU & RDMA Joint Allocation #192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f861327
to
c18a8df
Compare
c18a8df
to
2b05712
Compare
ZiMengSheng
reviewed
Dec 17, 2024
ZiMengSheng
reviewed
Dec 17, 2024
ZiMengSheng
reviewed
Dec 17, 2024
2b05712
to
1f0c4f9
Compare
ZiMengSheng
reviewed
Dec 19, 2024
d68042b
to
7da5817
Compare
saintube
reviewed
Dec 20, 2024
songtao98
reviewed
Dec 23, 2024
2cc1a92
to
8bcbb07
Compare
saintube
reviewed
Feb 18, 2025
8bcbb07
to
8f453cb
Compare
Signed-off-by: iostream2008@163.com <iostream2008@163.com> Signed-off-by: wangjianyu <wangjianyu.wjy@alibaba-inc.com>
8f453cb
to
82e1851
Compare
saintube
approved these changes
Feb 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
Since Gpus in AI scenarios require RDMA computing nics for high-speed NCCL communication, end-to-end support for rdma devices must be added, including device discovery, device registration, node resource update, scheduling, and allocation.
Ⅱ. Does this pull request fix one issue?
No
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
I have written necessary docs and comments
I have added necessary unit tests and integration tests
All checks passed in make test