Skip to content

KKP UI: Update docs related to remove support of Equinix Provider #1962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 8, 2025
Merged

KKP UI: Update docs related to remove support of Equinix Provider #1962

merged 3 commits into from
Sep 8, 2025

Conversation

KhizerRehan
Copy link
Contributor

No description provided.

@kubermatic-bot kubermatic-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 20, 2025
@kubermatic-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubermatic-bot kubermatic-bot added dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 20, 2025
@KhizerRehan KhizerRehan force-pushed the drop-support-equinix-provider branch from 2409b42 to df5c01c Compare August 21, 2025 09:30
@kubermatic-bot kubermatic-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 21, 2025
@KhizerRehan KhizerRehan changed the title WIP: KKP UI: Update docs related to remove support of Equinix Provider KKP UI: Update docs related to remove support of Equinix Provider Sep 8, 2025
@KhizerRehan KhizerRehan marked this pull request as ready for review September 8, 2025 08:41
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 8, 2025
KhizerRehan
KhizerRehan commented Sep 8, 2025
View reviewed changes
Copy link
Contributor Author

@KhizerRehan KhizerRehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added Comments for Reviewer

.../kubermatic/main/tutorials-howtos/administration/admin-panel/presets-management/_index.en.md
@@ -82,10 +82,6 @@ spec:
securityGroups:
routerID:
subnetID:
packet:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note:
Still present in the CRD but I’ve updated this example for now. The backend will be updated soon to remove the NOOP annotation from the CRD.

Any thoughts or concerns?

content/kubermatic/main/tutorials-howtos/administration/dynamic-data-centers/_index.en.md
Comment on lines -162 to -172
#==================================
#============= Packet =============
#==================================
packet-ams1:
location: "Packet AMS1 (Amsterdam)"
country: NL
spec:
packet:
facilities:
- ams1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note:
Updated this example as the packet-* provider will be removed later.

content/kubermatic/main/data/seed.ce.yaml
@@ -357,11 +357,6 @@ spec:
rhel: ""
rockylinux: ""
ubuntu: ""
# Deprecated: The Packet / Equinix Metal provider is deprecated and will be REMOVED IN VERSION 2.29.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note:

The Packet/Equinix Metal provider is deprecated and a NOOP. It is still present in the CRD (Ref: PR). I am not sure yet if it needs to be removed, but I’ve updated this example in advance. The backend will remove the NOOP annotation from the CRD later (IMHO)

thoughts?

Waseem826
Waseem826 approved these changes Sep 8, 2025
View reviewed changes
Copy link
Contributor

@Waseem826 Waseem826 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2025
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 64b8975022f22107203044055b9be743a7b7954a

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Waseem826

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2025
@kubermatic-bot kubermatic-bot merged commit 6edf26e into kubermatic:main Sep 8, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Waseem826 Waseem826 Waseem826 approved these changes

@ahmadhamzh ahmadhamzh Awaiting requested review from ahmadhamzh

Assignees

@Waseem826 Waseem826

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KhizerRehan @kubermatic-bot @Waseem826