Skip to content

[Draft] Try to address the cloudbase init running order #1719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Draft] Try to address the cloudbase init running order #1719

wants to merge 1 commit into from
+18 −15

Conversation

zylxjtu
Copy link
Contributor

@zylxjtu zylxjtu commented Apr 24, 2025

Change description

Related issues

  • Fixes #

Additional context

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kkeshavamurthy for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 24, 2025
@zylxjtu zylxjtu changed the title [Drafe] Try to address the cloudbase init running order [Draft] Try to address the cloudbase init running order Apr 24, 2025
kkeshavamurthy
kkeshavamurthy reviewed May 13, 2025
View reviewed changes
env.sh
Comment on lines +1 to +4
export AZURE_LOCATION="uksouth"
export AZURE_CLIENT_ID="aa0caef4-31da-4426-9908-f75af27075c8"
export AZURE_SUBSCRIPTION_ID="1c8c4edc-b188-4199-9580-3173033d75f7"
export USE_AZURE_CLI_AUTH=true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you prob want to remove this file from the draft :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

sriramandev
sriramandev reviewed May 16, 2025
View reviewed changes
images/capi/ansible/windows/roles/cloudbase-init/tasks/main.yml
# If this file already exists then the following command fails
Remove-Item -Force {{ systemdrive.stdout | trim }}\Windows\Setup\Scripts\SetupComplete.cmd
& "{{ programfiles.stdout | trim }}\Cloudbase Solutions\Cloudbase-Init\bin\SetSetupComplete.cmd"
cmd /c sc config cloudbase-init depend= WindowsAzureGuestAgent start= auto
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whats the impact of this on non-Azure systems or providers?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc: @laozc

sriramandev
sriramandev reviewed May 16, 2025
View reviewed changes
images/capi/packer/azure/scripts/sysprep.ps1
@@ -25,15 +25,17 @@ if( Test-Path $Env:SystemRoot\system32\Sysprep\unattend.xml ) {
Remove-Item $Env:SystemRoot\system32\Sysprep\unattend.xml -Force
}

$unattendedXml = "$ENV:ProgramFiles\Cloudbase Solutions\Cloudbase-Init\conf\Unattend.xml"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removal of this might break things. Might want to confirm this change

@laozc
Copy link
Member

laozc commented May 16, 2025

Could you elaborate a little bit more why it's needed? Is it specific for Azure?

@AverageMarcus
Copy link
Member

/lifecycle stale

I think this PR is no longer being worked on. @zylxjtu If you're still working on this please feel free to remove the stale label.

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 8, 2025
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkeshavamurthy kkeshavamurthy kkeshavamurthy left review comments

@CecileRobertMichon CecileRobertMichon Awaiting requested review from CecileRobertMichon

@jsturtevant jsturtevant Awaiting requested review from jsturtevant

+1 more reviewer

@sriramandev sriramandev sriramandev left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@zylxjtu @k8s-ci-robot @laozc @AverageMarcus @k8s-triage-robot @kkeshavamurthy @sriramandev