Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flannel] Update from 0.22.0 to 0.26.5 #12071

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mkl262
Copy link

@mkl262 mkl262 commented Mar 23, 2025

What type of PR is this?
/kind feature

What this PR does / why we need it:
This PR updates
Which issue(s) this PR fixes:
None

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
Yes

This update adds 2 variables to flannel:
1. `flannel_enable_nftables` - If set to true, flannel uses nftables instead of iptables to masquerade the traffic. Defaults to false
2.`flannel_daemonset_arch_list` - list of architecture specific Daemonsets to be created, only amd64 by default.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Mar 23, 2025
Copy link

linux-foundation-easycla bot commented Mar 23, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Mar 23, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mkl262
Once this PR has been reviewed and has the lgtm label, please assign ant31 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Welcome @mkl262!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 23, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @mkl262. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 23, 2025
@tico88612
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 24, 2025
@tico88612
Copy link
Member

@mkl262 Could you make your release-note briefly? (You put your current release-note in the commit content.)

@mkl262
Copy link
Author

mkl262 commented Mar 24, 2025

@tico88612 Im not sure I understand what you meant.
Also, I see that CI failes because of a timeout waiting for /run/flannel/subnet.env, but I dont see this issue in my tests, could it happen because I removed custom flannel image repos from tests/common_vars.yml file?

@tico88612
Copy link
Member

Im not sure I understand what you meant.

Release note is minimized to one line as much as possible (this will be in the Release description), and I don't think you need to update the magnitude to multiple lines.

These details should be put in docs/ or roles/network_plugin/flannel/defaults/main.yml.

Also, I see that CI failes because of a timeout waiting for /run/flannel/subnet.env, but I dont see this issue in my tests, could it happen because I removed custom flannel image repos from tests/common_vars.yml file?

Nope, because CI tests are frequent, this will trigger a rate limit if DockerHub is used.
@yankay Could you help me upload the new verison of Flannel? Thanks!

@tico88612
Copy link
Member

/retest-failed

@tico88612
Copy link
Member

/retest

@ant31
Copy link
Contributor

ant31 commented Mar 25, 2025

Hi, could you rebase master ?

@mkl262
Copy link
Author

mkl262 commented Mar 26, 2025

@tico88612 @ant31
Done

Copy link
Member

@tico88612 tico88612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix your pre-commit error message and these reviews.

@mkl262 mkl262 requested a review from tico88612 March 27, 2025 12:48
@mkl262
Copy link
Author

mkl262 commented Mar 27, 2025

@tico88612 Done, who can push the updated images to the kubespray repository?

@mkl262
Copy link
Author

mkl262 commented Apr 1, 2025

@tico88612 @yankay Can you please push the image?

@yankay
Copy link
Member

yankay commented Apr 1, 2025

@tico88612 @yankay Can you please push the image?

My pleasure, It has been pushed.
/retest

@mkl262
Copy link
Author

mkl262 commented Apr 3, 2025

@yankay @tico88612 Is there a way to see container logs? I cant recreate the issue.

@tico88612
Copy link
Member

@mkl262 Click the failing job, you can see that all the checks fail except kub-3. Maybe the template needs to be modified?
https://gitlab.com/kargo-ci/kubernetes-sigs-kubespray/-/jobs/9587738496

@tico88612
Copy link
Member

/retitle [flannel] Update from 0.22.0 to 0.26.5

@k8s-ci-robot k8s-ci-robot changed the title Update flannel [flannel] Update from 0.22.0 to 0.26.5 Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants