Skip to content

promote dns v1.26.0 images #8095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

promote dns v1.26.0 images #8095

wants to merge 2 commits into from

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented May 14, 2025 

(base) ➜  ~ for i in "k8s-dns-dnsmasq-nanny" "k8s-dns-kube-dns" "k8s-dns-sidecar" "k8s-dns-node-cache"; do for j in "" "-amd64" "-arm" "-arm64" "-ppc64le" "-s390x"; do echo $i$j; docker pull gcr.io/k8s-staging-dns/$i$j:1.26.0 | grep Digest; done; done

k8s-dns-dnsmasq-nanny
Digest: sha256:6ff5a6c3f305bd3f55a79f487af3868c646c65337840a950d7928aba7007cb70
k8s-dns-dnsmasq-nanny-amd64
Digest: sha256:1e2afaa5c8448eb8184c6cdb1ffb51909648a8e01bd76a7023687f6302c333fb
k8s-dns-dnsmasq-nanny-arm
Digest: sha256:f74a9de3adc37823f2bc157eda4db72f7675996b740137b29d72ebbc7e8dc831
k8s-dns-dnsmasq-nanny-arm64
Digest: sha256:51e34cc3f4a8bf2f5c54125eae214d9c0d32ac3b88934fd839eabc33d4d28c67
k8s-dns-dnsmasq-nanny-ppc64le
Digest: sha256:61ac8dd93d09b50880a2099ef2317b68bd3de2f9c13f203a6b2aa465be2b070f
k8s-dns-dnsmasq-nanny-s390x
Digest: sha256:2f0f73c7db49e36f1a65cb200adf674f09b23eea3f3d1fb22cfc95a16dbaf036
k8s-dns-kube-dns
Digest: sha256:09372b95f7bdbee57c0ee043da859fbc35e53c6bba12e95dbbe8c7be3c38133d
k8s-dns-kube-dns-amd64
Digest: sha256:4d0bb21b5f722f4776ea5d306847b0fab3f9b882f24fd081bfeaeb6207533f00
k8s-dns-kube-dns-arm
Digest: sha256:b842f471119d4b384c202f311e6d3f9fdddc006af688a7c3db6c1cec21cb68da
k8s-dns-kube-dns-arm64
Digest: sha256:7e4c8ef3d6b6eff58e8934029fb7a0f5289adaa98fa06bd6632df77c3ce19efa
k8s-dns-kube-dns-ppc64le
Digest: sha256:eb812f89437af84b90fff81e8c79dc303b52c4470d2937ad974a2ac61841e16b
k8s-dns-kube-dns-s390x
Digest: sha256:517facfa712201c461c63c007522ffd9d7fde3981da4278ade10e01c82766cd8
k8s-dns-sidecar
Digest: sha256:dcb1ecb6588ac79697603dfafd6c61d5d2361d6c9cb0384315443251852693c6
k8s-dns-sidecar-amd64
Digest: sha256:3a174fa9dd8bc24770631704320027dfab23abd82437b03fd4725177a2835f75
k8s-dns-sidecar-arm
Digest: sha256:4dc769c841cc4e5af9d436190feb5c51e4f11dd0717629d6c307fd812c913d16
k8s-dns-sidecar-arm64
Digest: sha256:f3718362513848f729bedd0d68bf62c2632bcd1b3749f1d0ba6274f3edf186e1
k8s-dns-sidecar-ppc64le
Digest: sha256:e01057509fa4ae81583d2d8ffd14ec448338ecff9355e8343d95bff8a9714a8c
k8s-dns-sidecar-s390x
Digest: sha256:aa05fac75f457b70108ba054de8bd6f49f7a1bcefeb459f83656f2dddff51ca8
k8s-dns-node-cache
Digest: sha256:3ddee59877cfea79efc11e455287ed078faec8d33c008e45e225f22f6e8ecb63
k8s-dns-node-cache-amd64
Digest: sha256:9e3c25e0296ea6a9bd90611a2ea5412d348d1044f5e7f805c8f6b6b6f5624943
k8s-dns-node-cache-arm
Digest: sha256:95680b15d33132f05e265d77fa8efbef0b1915dcce52dd216ace4aa4b08f97a9
k8s-dns-node-cache-arm64
Digest: sha256:4dc9b2d9c1e0ec6de14aa61b7c8a94e0cf2e629b3a02d53b82fb55854970e236
k8s-dns-node-cache-ppc64le
Digest: sha256:e8a0d7afcd744552c5e363cf245d723a066d6c65fad2b023b0b1c021f5da9959
k8s-dns-node-cache-s390x
Digest: sha256:1893585acd6ac45f272618cec23df574530df44b7245bb578f279bef70f0f887

https://github.com/kubernetes/dns/releases/tag/1.26.0

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 14, 2025
@k8s-ci-robot k8s-ci-robot requested review from bowei and MrHohn May 14, 2025 01:48
@k8s-ci-robot k8s-ci-robot added area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/registry.k8s.io Code in registry.k8s.io/ sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 14, 2025
@pacoxu
Copy link
Member Author

pacoxu commented May 14, 2025

/cc @DamianSawicki
/assign @kl52752

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pacoxu
Once this PR has been reviewed and has the lgtm label, please ask for approval from kl52752. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pacoxu
Copy link
Member Author

pacoxu commented May 14, 2025

The second commit is to add @DamianSawicki to approver list since he is owner of dns. https://github.com/kubernetes/dns/blob/master/OWNERS

@DamianSawicki
Copy link
Contributor

I was just going to do the promotion, so thanks so much for taking care of it instead!

One request: there was a vulnerability PR merged yesterday, so I already cut 1.26.1. Could you please promote it instead (or both)?

@pacoxu
Copy link
Member Author

pacoxu commented May 14, 2025

I was just going to do the promotion, so thanks so much for taking care of it instead!

One request: there was a vulnerability PR merged yesterday, so I already cut 1.26.1. Could you please promote it instead (or both)?

OK. I will add 1.26.1 ASAP.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 14, 2025
@pacoxu
Copy link
Member Author

pacoxu commented May 14, 2025 

(base) ➜  ~ for i in "k8s-dns-dnsmasq-nanny" "k8s-dns-kube-dns" "k8s-dns-sidecar" "k8s-dns-node-cache"; do for j in "" "-amd64" "-arm" "-arm64" "-ppc64le" "-s390x"; do echo $i$j; docker pull gcr.io/k8s-staging-dns/$i$j:1.26.1 | grep Digest; done; done

k8s-dns-dnsmasq-nanny
Digest: sha256:d7251562d4d0f3324fd279384538ad7d27806254097ca3a50415e06991cd21dc
k8s-dns-dnsmasq-nanny-amd64
Digest: sha256:4ba134fc09481849fd1f059993203d346a33e951ba6dee013dfe0c6ab2bd3bc2
k8s-dns-dnsmasq-nanny-arm
Digest: sha256:0a74e00d1271d0c6b3dc58da55bbe48e383ec3535f8f0e7801d96df755031ab3
k8s-dns-dnsmasq-nanny-arm64
Digest: sha256:37ed0836740822612ad12c8031dc166e0e5a52a72846ebc7109888d300b30f95
k8s-dns-dnsmasq-nanny-ppc64le
Digest: sha256:f97e70c345929d44f08a68b314278c00ff419fcd68ed2aaced7c2c04a70bfd28
k8s-dns-dnsmasq-nanny-s390x
Digest: sha256:ce59295d21e6383f970037458e7dd499c45da11882361f4be1e08f96ab353e14
k8s-dns-kube-dns
Digest: sha256:3df7552f4a0c67d209d8ab03d55319d6db8c43684131a73e23b8ae709c82acfa
k8s-dns-kube-dns-amd64
Digest: sha256:9925cb9275a79c08c0c7e46506a8761631c6913127b431e96b60909d84c845f8
k8s-dns-kube-dns-arm
Digest: sha256:554af83b2f26cc4d5c8f51dab8296fac0e018d42c4c1f73fa22e2c15faa38d8e
k8s-dns-kube-dns-arm64
Digest: sha256:fc8b2b15dc872b470d885d58aacad15dab777c40b51921020dc340b79c0ac638
k8s-dns-kube-dns-ppc64le
Digest: sha256:ef1d330f1fedc2a259af2da967262d930a8d5b7898cdfa30f36b49fb9162b780
k8s-dns-kube-dns-s390x
Digest: sha256:842966d4d717aa5fa53b4b4e9ae79509ecabc42d67640533d46a6e058994f517
k8s-dns-sidecar
Digest: sha256:95102ef250e8c2b97423a2acf08b7a2420488eb8878d1647a372e7b0c466621b
k8s-dns-sidecar-amd64
Digest: sha256:26781489ffad502cf91ded9e01b13b2f0ecd31bcb62f47c3dcb6a1330ab33e25
k8s-dns-sidecar-arm
Digest: sha256:b5b639e9d51822f318c282967ccc162b735e47e1e518fff2ea28bc6b18ea6a62
k8s-dns-sidecar-arm64
Digest: sha256:998e009a641d6cd244011257b031ef13dc631adf4c8647ca09d57fb54783a1ec
k8s-dns-sidecar-ppc64le
Digest: sha256:1481f06a9f14def612242d79193e293d117b30f9fff52889d3f55e24982be3fa
k8s-dns-sidecar-s390x
Digest: sha256:03073bf3b3fb16805d9e26421926a08cb112f2f700a642934c3972486fddd8c5
k8s-dns-node-cache
Digest: sha256:bab35b6e6a5cc4a43e107ffba84feb154a5196a64f24e07858e0931174d5be11
k8s-dns-node-cache-amd64
Digest: sha256:190bcc577f256ca8e37a9903f4d39edc0be245ca9b2b3181bca8fc61b343bd9e
k8s-dns-node-cache-arm
Digest: sha256:96360614e3dfd38fd59fe53ad2929b1a1c9855193374e2ec4fb31491dbb869ed
k8s-dns-node-cache-arm64
Digest: sha256:9c0ec6be7505e7001582c949fc3e8e5451f467d965060a263b9e817e69f8d2b0
k8s-dns-node-cache-ppc64le
Digest: sha256:ebac52bcd943d8598c6ed6ad36b8897eee92ac760d0671e2989aa99abdc52612
k8s-dns-node-cache-s390x
Digest: sha256:3befe1839540027ac44675d501c279ff3b1134aeab8ac5f81802a892502496a8

Added.

@DamianSawicki
Copy link
Contributor

DamianSawicki commented May 14, 2025 •
edited
Loading

OK. I will add 1.26.1 ASAP.

Thanks so much for your prompt reaction! Actually, there's lots of activity on kubernetes/dns right now, and I've just cut another tag 1.26.2. The images are building right now, and I think it would be great if we could include 1.26.2 in this PR as well. @pacoxu Could you possibly add 1.26.2 images when they become available?

In any case, I've reviewed the current version, and the changes to registry.k8s.io/images/k8s-staging-dns/images.yaml look correct.

Update: Actually, it seems that some follow-up on kubernetes/dns#685 will be needed to comprehensively address vulnerabilities, so 1.26.2 is not the desired state yet. We can merge the current PR as it is or wait for another PR in kubernetes/dns to cut 1.26.3 and include it here.

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels May 14, 2025
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@pacoxu
Copy link
Member Author

pacoxu commented May 15, 2025

1.26.3 is not ready yet.

I updated 1.26.2 in last commit.

(base) ➜  git for i in "k8s-dns-dnsmasq-nanny" "k8s-dns-kube-dns" "k8s-dns-sidecar" "k8s-dns-node-cache"; do for j in "" "-amd64" "-arm" "-arm64" "-ppc64le" "-s390x"; do echo $i$j; docker pull gcr.io/k8s-staging-dns/$i$j:1.26.2 | grep Digest; done; done

k8s-dns-dnsmasq-nanny
Digest: sha256:a7ce77be2ac6da2aa21e459e8155c60eef3ab8c6a64d50b5fe6247d54cb3c93d
k8s-dns-dnsmasq-nanny-amd64
Digest: sha256:a50f45b3bd437306e46d8912c8e37179d253af449d988709bcce8d59702c9787
k8s-dns-dnsmasq-nanny-arm
Digest: sha256:822491929dd4a859daba63d19ee13912eef63fb20ef35d2d9e3ea02e572f973e
k8s-dns-dnsmasq-nanny-arm64
Digest: sha256:706c619a6801712366148e0265a11edeb9ea292f425825e6a1bc2eb91edb0c78
k8s-dns-dnsmasq-nanny-ppc64le
Digest: sha256:b89c5b291e4a7e8b5aa726fb01748053e86038a649e7c1ecefb151acfa85c0a2
k8s-dns-dnsmasq-nanny-s390x
Digest: sha256:6c973b407f246135946514d18a6d603a1e3da36cc0ac7ec4d37be76a0c3cea4a
k8s-dns-kube-dns
Digest: sha256:6ea7f0d93a70f269c877f15eb9091f10240fd9b7155c2bb37808c3c8a1b3ba8d
k8s-dns-kube-dns-amd64
Digest: sha256:d2ea598d1f0b215057ecfc85191fb5764288ad95d768ca096a8d2ba2c8c3221c
k8s-dns-kube-dns-arm
Digest: sha256:72ab2f3dedf8095054c4cdd4949f290ca53844cc99846732a9545629594e4184
k8s-dns-kube-dns-arm64
Digest: sha256:2f97fe81d1dab0dd5c10853bdc469f4b2d381878d2a2e4b11db81bad13617005
k8s-dns-kube-dns-ppc64le
Digest: sha256:7c7b9a7a382286d709d7f44edc9b40c4ed7fca8b4ce74d8ce182954f006e1915
k8s-dns-kube-dns-s390x
Digest: sha256:a4ea0ea7fbab65f0a5fee2e6c485fa180143272d0420bc706b1e158729be7370
k8s-dns-sidecar
Digest: sha256:f425fc4678add3e5990e29266fb491a812ca454bbb5e40f0b11d35bdc4f3ca75
k8s-dns-sidecar-amd64
Digest: sha256:2f38f3fecd2a5a35753667b0eeee0971942f1e32f080ccc1837e2c8ccc3c651f
k8s-dns-sidecar-arm
Digest: sha256:8c967ae5d78670dbc4bd7bc402e853d9ec42d13fc91a5d3323ab59fe0f22b074
k8s-dns-sidecar-arm64
Digest: sha256:d7aebc8fedf2419f0d2c8cb9b28a3b63d15bfb57da882b516cb916272a2ec0a9
k8s-dns-sidecar-ppc64le
Digest: sha256:47e1e017b0eada0fb4571529d0d268c115c5f283a6cf8a7efce888570b2a0905
k8s-dns-sidecar-s390x
Digest: sha256:e820ced4599a55f6d419b92bacaab08325a75348e184de4fde4c365e96285040
k8s-dns-node-cache
Digest: sha256:89bf21b3b1237ec98d2bc97bc32d21c1c7e45617c9fc4cec7cb31c6aee3b22bf
k8s-dns-node-cache-amd64
Digest: sha256:bab7efbd4c4b182f1230ec4c30a099904aca727bc92b93451a76467d279f1bdc
k8s-dns-node-cache-arm
Digest: sha256:e3cbfe9e3aa4a1511561ba66096b3dfa18b75f5e95193da9b43eae937140da06
k8s-dns-node-cache-arm64
Digest: sha256:47a086db0ebce951844720e062c0273406123b3aad52ad8dc8271a0af98800a9
k8s-dns-node-cache-ppc64le
Digest: sha256:ca4a0751acde25236c229a9f15da74670ca8658eeddb706ec096b30e01a0c382
k8s-dns-node-cache-s390x
Digest: sha256:7fff9180ffa7a36192007126b1a1e3605e51b27bfa489375219b1ce9d8d22298

@DamianSawicki
Copy link
Contributor

Hi @pacoxu, thanks for following up!

Update: Actually, it seems that some follow-up on kubernetes/dns#685 will be needed to comprehensively address vulnerabilities, so 1.26.2 is not the desired state yet. We can merge the current PR as it is or wait for another PR in kubernetes/dns to cut 1.26.3 and include it here.

As I wrote above, 1.26.2 is not the desired state yet, so I don't see much value in promoting it. Ideally, I would like to get kubernetes/dns#681 merged, cut 1.26.3, and then promote it. To avoid too much mess, I'd prefer to promote 1.26.0 and 1.26.3 or just 1.26.3.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 16, 2025
@pacoxu
Copy link
Member Author

pacoxu commented May 16, 2025

As I wrote above, 1.26.2 is not the desired state yet, so I don't see much value in promoting it. Ideally, I would like to get kubernetes/dns#681 merged, cut 1.26.3, and then promote it. To avoid too much mess, I'd prefer to promote 1.26.0 and 1.26.3 or just 1.26.3.

Got it. Dropped v1.26.1/v1.26.2 and wait for your 1.26.3 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowei bowei Awaiting requested review from bowei

@MrHohn MrHohn Awaiting requested review from MrHohn

@DamianSawicki DamianSawicki Awaiting requested review from DamianSawicki

Assignees

@DamianSawicki DamianSawicki

@kl52752 kl52752

Labels
area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/registry.k8s.io Code in registry.k8s.io/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pacoxu @k8s-ci-robot @DamianSawicki @kl52752