Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow in-memory GCB jobs #3472

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Allow in-memory GCB jobs #3472

merged 1 commit into from
Feb 15, 2024

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Feb 15, 2024 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

This allows submitting GCB jobs via krel without having a need for the k/release repository available.

Which issue(s) this PR fixes:

Refers to #3473

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Added support for in-memory `cloudbuild.yaml` jobs when submitting them using `krel`.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/release-eng Issues or PRs related to the Release Engineering subproject labels Feb 15, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/release Categorizes an issue or PR as relevant to SIG Release. needs-priority size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 15, 2024
@saschagrunert
Allow in-memory GCB jobs
e0240bf 
This allows submitting GCB jobs via `krel` without having a need for the
k/release repository available.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@saschagrunert saschagrunert changed the title WIP: Allow in-memory GCB jobs Allow in-memory GCB jobs Feb 15, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 15, 2024
@saschagrunert
Copy link
Member Author

PTAL @kubernetes/release-managers

cpanato
cpanato approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is cool

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 15, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cpanato,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 1fe98d2 into kubernetes:master Feb 15, 2024
10 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Feb 15, 2024
@saschagrunert saschagrunert deleted the in-memory-jobs branch February 15, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@jrsapi jrsapi Awaiting requested review from jrsapi

@salaxander salaxander Awaiting requested review from salaxander

Assignees

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.30
Development

Successfully merging this pull request may close these issues.
3 participants
@saschagrunert @k8s-ci-robot @cpanato