Fix a bug of resetting the plan name validation field when resetting the plan #1429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… plan Whan going back in plan's wizard from step 2 to step 1 and updating the Plan's VMs list and then going next to step 2 again, the plan name field was not validated correctly and therefore the wizard was blocked. Signed-off-by: Sharon Gratch <sgratch@redhat.com>
|
metalice
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When going back in plan's wizard from
step 2tostep 1and updating the Plan's VMs checked list and then going next again tostep 2, the plan name field was not validated correctly and therefore the wizard was blocked even though the 'create migration plan' button was enabled - see screencast for the reproduced use case.Screencast before fix
Screencast.from.2025-01-06.18-44-56.webm
Screencast after fix
Screencast.from.2025-01-06.18-48-17.webm