Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTV-1883: Adding PR template #1434

Merged
merged 3 commits into from
Jan 14, 2025
Merged

Conversation

metalice
Copy link
Collaborator

MTV-1883: Adding PR template

https://issues.redhat.com/browse/MTV-1883

Signed-off-by: Matan Schatzman <mschatzm@redhat.com>
@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.20%. Comparing base (13484d0) to head (2335e26).
Report is 180 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1434      +/-   ##
==========================================
- Coverage   36.81%   36.20%   -0.62%     
==========================================
  Files         158      159       +1     
  Lines        2548     2580      +32     
  Branches      599      615      +16     
==========================================
- Hits          938      934       -4     
- Misses       1428     1451      +23     
- Partials      182      195      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@sgratch sgratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

I just suggest to change the sections order since it's more convenient for me to search for the bug reference first with the "References:" header,
then description and screenshots (which can be long)
and CC at the end, if needed.

.github/pull_request_template.md Outdated Show resolved Hide resolved
metalice and others added 2 commits January 14, 2025 15:03
Co-authored-by: Sharon Gratch <sgratch@redhat.com>
Signed-off-by: Matan Schatzman <matanschatzman@gmail.com>
Signed-off-by: Matan Schatzman <matanschatzman@gmail.com>
Copy link
Collaborator

@sgratch sgratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sgratch sgratch added the documentation Improvements or additions to documentation label Jan 14, 2025
@metalice metalice merged commit 3e12738 into kubev2v:main Jan 14, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants