Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set default platform based on host-architecture for linux bridge build. #1985

Conversation

ashokpariya0
Copy link
Contributor

What this PR does / why we need it:
We encountered an unexpected failure in the job pull-cluster-network-addons-operator-unit-test-release-0.97(in pr: #1983) while performing a multi-architecture build for the Linux bridge. As a result, to unblock, we have adjusted the default build process to target the host architecture rather than building for all architectures by default.

Special notes for your reviewer:

Release note:

None

Signed-off-by: Ashok Pariya <ashok.pariya@ibm.com>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jan 15, 2025
@kubevirt-bot
Copy link
Collaborator

Hi @ashokpariya0. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ashokpariya0
Copy link
Contributor Author

cc @oshoval

@oshoval
Copy link
Collaborator

oshoval commented Jan 15, 2025

Thanks
/lgtm

cc @RamLavi

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2025
@oshoval
Copy link
Collaborator

oshoval commented Jan 15, 2025

/retest

@oshoval
Copy link
Collaborator

oshoval commented Jan 15, 2025

/test all

@RamLavi
Copy link
Collaborator

RamLavi commented Jan 15, 2025

/lgtm

@oshoval
Copy link
Collaborator

oshoval commented Jan 15, 2025

/approve

@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oshoval

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2025
@kubevirt-bot kubevirt-bot merged commit c4484a7 into kubevirt:release-0.97 Jan 15, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants