Fix Clang warnings for -Wweak-vtables
#1254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already inherit a `virtual` destructor from `Window`. However, by providing an explicit `override` here, we now have a `virtual` member with an out-of-line definition, meaning the virtual function table can be emitted in only the translation unit that defines it. This removes an instance of the Clang warning `-Wweak-vtables`.
This creates out-of-line virtual method definitions. This removes an instance of the Clang warning `-Wweak-vtables`.
This creates an out-of-line virtual method definition. This removes an instance of the Clang warning `-Wweak-vtables`.
This creates an out-of-line virtual method definition. This removes an instance of the Clang warning `-Wweak-vtables`. As we move more code into class constructors, the `initialize()` method here becomes less important. For simple classes, it should be optional to write an explicit override.
This creates an out-of-line virtual method definition. This removes an instance of the Clang warning `-Wweak-vtables`.
This creates out-of-line virtual method definitions. This removes an instance of the Clang warning `-Wweak-vtables`.
This removes instances of the Clange warning `-Wweak-vtables`.
This removes an instance of the Clange warning `-Wweak-vtables`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure classes with
virtualmember functions have at least one out-of-line definition in their source file.Related: