-
Notifications
You must be signed in to change notification settings - Fork 2.7k
feat(langchain-oracle): Add Oracle Document Loader and Oracle Vector Search #8659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… into node-oracledbadjustments
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
@hackerdave thanks for the contribution 🙏 our team has been working on the upcoming v1 release of LangChain and unfortunately didn't had the resources yet to look at this PR. We will provide an update soon. |
|
||
## Connecting to Oracle Database | ||
|
||
Below is an example of how to connect to an Oracle Database using both a direct connection and a connection pool: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Split this into two examples. Make the second have a method e.g dbPoolConnection() to get a connection from the pool.
Consider adding links to the node-oracledb connection & pool creation doc sections:
- https://node-oracledb.readthedocs.io/en/latest/user_guide/connection_handling.html#standalone-connections
- https://node-oracledb.readthedocs.io/en/latest/user_guide/connection_handling.html#creating-a-connection-pool
Examples later in the doc need connecting handling to be consistent. E.g. the "Testing the Integration" example calls both dbPool() and dbConnect(). The latter call should be changed to invoke the new dbPoolConnection() method.
@hackerdave @cjbj what's your thoughts on splitting this into its own repo similar to how the python integration is? We're trying to scope down on the amount of maintenance footprint this repo has. |
@hntrl I'll defer to @hackerdave on this. |
Yes we are looking into splitting the repo like the python integration so langchain-oracle would be in the oracle repo. It will take a month to get approvals. Should the documentation (i.e., cookbook and docs) remain in the langchain-ai repo? |
@hackerdave Going forward, it's probably best to add docs to the docs repo |
Description
This PR integrates Oracle Document Loader and Oracle Vector Search with LangChain.js. The integration enables the use of Oracle's advanced vector search capabilities within the LangChain.js framework.
Key Features
Example usage
Text Splitter
Embeddings
Testing